fix: keep client default client read limit when realtime doesn't specify #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is mostly for internal purposes, where we have rate limits of 0 (read: unlimited). When 0 is received from realtime, the SDK should continue with its existing defaults.
github-actions
bot
temporarily deployed
to
staging/pull/631/features
sacOO7
reviewed
Feb 1, 2024
github-actions
bot
temporarily deployed
to
staging/pull/631/features
sacOO7
requested changes
Feb 1, 2024
Co-authored-by: sachin shinde <[email protected]>
github-actions
bot
temporarily deployed
to
staging/pull/631/features
Co-authored-by: sachin shinde <[email protected]>
Co-authored-by: sachin shinde <[email protected]>
github-actions
bot
temporarily deployed
to
staging/pull/631/features
github-actions
bot
temporarily deployed
to
staging/pull/631/features
github-actions
bot
temporarily deployed
to
staging/pull/631/features
sacOO7
force-pushed
the
connection-read-limit-unlimited
branch
from
6b6b43a to
e85f788
Compare
|
@AndyTWF do try running the test and check if |
|
LGTM - nicely done 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly for internal purposes, where we have MaxMessageSize set to 0 (read: unlimited). When this happens, the SDK should keep whatever limit it currently has set.
Previously it was trying to set 0 which prevented anything from being read from the connection/