Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reconnection issue #640

Merged
merged 2 commits into from
Jun 28, 2024
Merged

Fix reconnection issue #640

merged 2 commits into from
Jun 28, 2024

Conversation

sacOO7
Copy link
Collaborator

@sacOO7 sacOO7 commented Jun 28, 2024 •
edited
Loading

Fixed #638

  • Fixed getMode() usage, it should be invoked for every connection attempt.
  • Earlier it was invoked only once for first retry.

@github-actions github-actions bot temporarily deployed to staging/pull/640/features June 28, 2024 11:17 Inactive
@sacOO7 sacOO7 changed the title Fix reconnection issue when channel goes into suspended state Fix reconnection issue Jun 28, 2024
@github-actions github-actions bot temporarily deployed to staging/pull/640/godoc June 28, 2024 11:17 Inactive
@sacOO7 sacOO7 marked this pull request as ready for review June 28, 2024 14:35
@sacOO7 sacOO7 requested review from umair-ably and AndyTWF June 28, 2024 14:36
umair-ably
umair-ably approved these changes Jun 28, 2024
View reviewed changes
Copy link

@umair-ably umair-ably left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sacOO7
Copy link
Collaborator Author

sacOO7 commented Jun 28, 2024

Thanks @umair-ably

@sacOO7 sacOO7 merged commit d1167b5 into main Jun 28, 2024
7 of 8 checks passed
@sacOO7 sacOO7 deleted the fix/reconnect-when-suspended branch June 28, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umair-ably umair-ably umair-ably approved these changes

@AndyTWF AndyTWF Awaiting requested review from AndyTWF

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Suspended connection goes to failed state on resume attempt
2 participants
@sacOO7 @umair-ably