Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Synthetic presence leave #649

Merged
merged 7 commits into from
Jul 25, 2024
Merged

Synthetic presence leave #649

merged 7 commits into from
Jul 25, 2024

Conversation

sacOO7
Copy link
Collaborator

@sacOO7 sacOO7 commented Jul 24, 2024

Fixed #646

@github-actions github-actions bot temporarily deployed to staging/pull/649/godoc July 24, 2024 07:21 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/649/features July 24, 2024 07:21 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/649/godoc July 24, 2024 11:31 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/649/features July 24, 2024 11:31 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/649/features July 24, 2024 12:30 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/649/godoc July 24, 2024 12:31 Inactive
@sacOO7 sacOO7 force-pushed the fix/synthetic-presence-leave branch from 05bb083 to cfd4ecd Compare July 24, 2024 13:35
@github-actions github-actions bot temporarily deployed to staging/pull/649/godoc July 24, 2024 13:36 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/649/features July 24, 2024 13:36 Inactive
@sacOO7 sacOO7 force-pushed the fix/synthetic-presence-leave branch from cfd4ecd to 511f4c1 Compare July 24, 2024 18:03
@github-actions github-actions bot temporarily deployed to staging/pull/649/features July 24, 2024 18:04 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/649/godoc July 24, 2024 18:04 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/649/godoc July 24, 2024 18:54 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/649/features July 24, 2024 18:54 Inactive
@sacOO7 sacOO7 marked this pull request as ready for review July 24, 2024 18:58
@sacOO7 sacOO7 requested review from ttypic and AndyTWF July 24, 2024 18:59
@github-actions github-actions bot temporarily deployed to staging/pull/649/features July 25, 2024 05:38 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/649/godoc July 25, 2024 05:38 Inactive
ttypic
ttypic approved these changes Jul 25, 2024
View reviewed changes
Copy link

@ttypic ttypic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@sacOO7 sacOO7 merged commit e6ad4bf into main Jul 25, 2024
14 checks passed
@sacOO7 sacOO7 deleted the fix/synthetic-presence-leave branch July 25, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttypic ttypic ttypic approved these changes

@AndyTWF AndyTWF Awaiting requested review from AndyTWF

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A synthetic leave does not trigger the presence event listener callback
2 participants
@sacOO7 @ttypic