-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed use of deprecated ioutil #664
Conversation
WalkthroughThe changes across various files involve replacing deprecated Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant Server
Client->>Server: Send HTTP Request
Server->>Server: Read Request Body using io.ReadAll
Server-->>Client: Send HTTP Response
Client->>Server: Process Response using io.ReadAll
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (7)
- ably/auth.go (3 hunks)
- ably/error.go (2 hunks)
- ably/rest_client.go (3 hunks)
- ably/rest_client_integration_test.go (3 hunks)
- ablytest/proxies.go (2 hunks)
- ablytest/recorders.go (3 hunks)
- ablytest/sandbox.go (2 hunks)
Files skipped from review due to trivial changes (6)
- ably/auth.go
- ably/error.go
- ably/rest_client.go
- ably/rest_client_integration_test.go
- ablytest/proxies.go
- ablytest/sandbox.go
Additional comments not posted (1)
ablytest/recorders.go (1)
248-249
: Change toio.NopCloser
is appropriate.The update from
ioutil.NopCloser
toio.NopCloser
is correct and aligns with the deprecation of theioutil
package. The functionality remains consistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ioutil
module is replaced byio
oros
since go 1.16Summary by CodeRabbit
Bug Fixes
ioutil
package functions withio
package functions to enhance code stability and clarity across multiple components.Refactor
ioutil
package, improving adherence to current best practices in Go programming.These changes ensure better maintainability and performance of the application.