-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WEB-4164] Tweak pricing card colours #591
Conversation
This matches the classes on "consumption" string just above
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThis pull request involves two primary changes: updating the package version in Changes
Assessment against linked issues
Possibly related PRs
Suggested reviewers
Poem
Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a note to update the package version before merging
@@ -73,7 +73,7 @@ export const planData: PricingDataFeature[] = [ | |||
cta: { | |||
text: "Get started", | |||
url: "/users/paid_sign_up?package=standard", | |||
iconColor: "text-blue-600 dark:text-blue-400", | |||
iconColor: "text-gui-blue-default-dark dark:text-gui-blue-default-light", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a bit weird we still have these non-numerical colour variants that sit outside of the numerical palettes, seems like a mix of approaches - but if this is the request, this is the request (these aren't aliases of existing numerical palette colours).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jamiehenson I thought the same, but these are the colours in Figma ¯\_(ツ)_/¯
e60ac6a
to
13b70ad
Compare
Jira Ticket Link / Motivation
Following on from #582, some additional tweaks to move us closer to the designs:
See the comments on WEB-4164 for the discussion that lead to this PR
Summary of changes
This pull request includes updates to the
package.json
file and changes to theplanData
insrc/core/Pricing/data.tsx
to modify the icon colors for different CTA buttons.Version update:
package.json
: Updated the version number from15.1.13
to15.1.14
.Icon color adjustments:
src/core/Pricing/data.tsx
: ChangediconColor
for the "Start for free" CTA button totext-neutral-600 dark:text-neutral-700
.src/core/Pricing/data.tsx
: UpdatediconColor
for the "Get started" CTA button for the standard package totext-gui-blue-default-dark dark:text-gui-blue-default-light
.src/core/Pricing/data.tsx
: UpdatediconColor
for the "Get started" CTA button for the pro package totext-gui-blue-default-dark dark:text-gui-blue-default-light
.How do you manually test this?
📖
Merge/Deploy Checklist
Frontend Checklist
Summary by CodeRabbit
Version Update
Style