-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EDU-1654] - Add generate Ably token authentication example #2322
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
ce90cf7
to
fb70c3c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is going to be really useful, couple of suggestions:
I'd suggest that we have the steps already printed out, and then as they occur they receive a tick at the end of line. I think this might show the speed a bit more clearly, and also avoid the fact you can keep pushing 'connect'.
I know we spoke about it previously, but I think it would be worth expanding on all the steps and adding in everything that happens, even if some of it is server-side.
1. Client requests token from server
2. Client initializes connection to Ably with generated Token
Minor point: I think having a title like "Welcome to the Ably Token Manager" makes the process seem a bit more grandiose, when it's supposed to be (is) quite simple. Thoughts?
1d93f9a
to
8bed8ce
Compare
fb70c3c
to
ef141a1
Compare
b7c49fc
to
355032a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, the only suggestion is to use ably/react
for react example. Probably it will be a bit more code, but it will show that we recommend our react hooks for react apps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: should the directory be "auth-request-token" rather than generate?
Minor suggestions but LGTM 🙂
e73db59
to
f91deaf
Compare
a7ccc91
to
b212e64
Compare
This PR contains the two code samples for the new Examples section we are creating. It contains a Typescript and a React version for authentication requesting an access token from a backend server. This is a different structure example to most. This one requires a server to be running to generate the token so I've created an example for this in the server directory.
The README within each directory
/examples/auth-generate-token/javascript
and/examples/auth-generate-token/react
contains information on how to get these running.Jira epic ticket
Jira ticket.