Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EDU-1654] - Add generate Ably token authentication example #2322

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

GregHolmes
Copy link
Contributor

@GregHolmes GregHolmes commented Dec 2, 2024

This PR contains the two code samples for the new Examples section we are creating. It contains a Typescript and a React version for authentication requesting an access token from a backend server. This is a different structure example to most. This one requires a server to be running to generate the token so I've created an example for this in the server directory.

The README within each directory /examples/auth-generate-token/javascript and /examples/auth-generate-token/react contains information on how to get these running.

Jira epic ticket
Jira ticket.

@GregHolmes GregHolmes self-assigned this Dec 2, 2024
Copy link

coderabbitai bot commented Dec 2, 2024

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ably-ci ably-ci temporarily deployed to ably-docs-edu-1654-exam-yhgacq December 2, 2024 18:01 Inactive
@GregHolmes GregHolmes force-pushed the EDU-1541-DevJourney-Examples branch 2 times, most recently from ce90cf7 to fb70c3c Compare December 6, 2024 09:27
Copy link
Contributor

@m-hulbert m-hulbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to be really useful, couple of suggestions:

I'd suggest that we have the steps already printed out, and then as they occur they receive a tick at the end of line. I think this might show the speed a bit more clearly, and also avoid the fact you can keep pushing 'connect'.

I know we spoke about it previously, but I think it would be worth expanding on all the steps and adding in everything that happens, even if some of it is server-side.

1. Client requests token from server
2. Client initializes connection to Ably with generated Token

Minor point: I think having a title like "Welcome to the Ably Token Manager" makes the process seem a bit more grandiose, when it's supposed to be (is) quite simple. Thoughts?

examples/auth-generate-token/page.md Outdated Show resolved Hide resolved
examples/auth-generate-token/page.md Outdated Show resolved Hide resolved
examples/auth-generate-token/page.md Outdated Show resolved Hide resolved
examples/auth-generate-token/page.md Outdated Show resolved Hide resolved
examples/auth-generate-token/page.md Outdated Show resolved Hide resolved
examples/auth-generate-token/page.md Outdated Show resolved Hide resolved
examples/auth-generate-token/page.md Outdated Show resolved Hide resolved
examples/auth-generate-token/page.md Outdated Show resolved Hide resolved
@GregHolmes GregHolmes force-pushed the EDU-1654-Example-Pub-Sub-Generate-JWT branch from 1d93f9a to 8bed8ce Compare December 6, 2024 11:48
@GregHolmes GregHolmes temporarily deployed to ably-docs-edu-1654-exam-yhgacq December 6, 2024 11:49 Inactive
@GregHolmes GregHolmes force-pushed the EDU-1541-DevJourney-Examples branch from fb70c3c to ef141a1 Compare December 16, 2024 09:28
Base automatically changed from EDU-1541-DevJourney-Examples to main December 16, 2024 09:35
@GregHolmes GregHolmes force-pushed the EDU-1654-Example-Pub-Sub-Generate-JWT branch from b7c49fc to 355032a Compare December 16, 2024 09:44
@GregHolmes GregHolmes changed the title [EDU-1654] - Add generate JWT authentication example [EDU-1654] - Add generate Ably token authentication example Dec 16, 2024
Copy link

@ttypic ttypic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, the only suggestion is to use ably/react for react example. Probably it will be a bit more code, but it will show that we recommend our react hooks for react apps

Copy link
Contributor

@m-hulbert m-hulbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: should the directory be "auth-request-token" rather than generate?

Minor suggestions but LGTM 🙂

examples/auth-generate-token/page.md Outdated Show resolved Hide resolved
examples/auth-generate-token/page.md Outdated Show resolved Hide resolved
examples/auth-generate-token/page.md Outdated Show resolved Hide resolved
@GregHolmes GregHolmes force-pushed the EDU-1654-Example-Pub-Sub-Generate-JWT branch from e73db59 to f91deaf Compare December 18, 2024 16:38
@GregHolmes GregHolmes force-pushed the EDU-1654-Example-Pub-Sub-Generate-JWT branch from a7ccc91 to b212e64 Compare December 18, 2024 16:53
@GregHolmes GregHolmes merged commit 31b11d6 into main Dec 18, 2024
5 checks passed
@GregHolmes GregHolmes deleted the EDU-1654-Example-Pub-Sub-Generate-JWT branch December 18, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants