-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EDU-1669] - Add PubSub example for channels and messages #2323
base: main
Are you sure you want to change the base?
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
86e6d75
to
ce90cf7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Example is looking good, but a few things:
- You're adding all the examples in this PR.
- The
page.md
hasn't been updated and is still referencing Chat. - After the 10 headlines, we publish
undefined
when you click the button which looks bad. We'd be better off disabling the publish button. - Do you think it's worth having an input box for users to enter their own headline too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also forgot to suggest that we reverse the order of the feed (so newest is at the top), as I would say that's more common in a news feed. WDYT?
ce90cf7
to
fb70c3c
Compare
fc24587
to
8b5e17c
Compare
fb70c3c
to
ef141a1
Compare
8b5e17c
to
33155c3
Compare
This PR contains the two code samples for the new Examples section we are creating. It contains a Typescript and a React version for channels and messages with Pub/Sub. Which will be rendered in the code sandbox live examples in the future, along with others.
The README within each directory /examples/pub-sub-channel-messages/javascript and /examples/pub-sub-channel-messages/react contains information on how to get these running.
Jira epic ticket
Jira ticket.