[WEB-4100] - new design footer #2330
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe changes involve a significant restructuring of the footer component in the application. The Changes
Assessment against linked issues
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
aralovelace
changed the title
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
aralovelace
force-pushed
the
WEB-4100_Footer
branch
from
7842522 to
17075f2
Compare
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🧹 Outside diff range and nitpick comments (1)
src/components/Footer/FooterStatus.tsx (1)
52-53: Include 'noopener' in the 'rel' attribute for securityWhen using
target="_blank", it is recommended to include'noopener'in therelattribute to prevent potential security risks related to thewindow.openerproperty.Apply this diff to enhance security:
- rel="noreferrer" + rel="noopener noreferrer"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (3)
src/components/Footer/FooterTopNav/images/ably-logo.pngis excluded by!**/*.pngsrc/components/blocks/Html/__snapshots__/Html.test.tsx.snapis excluded by!**/*.snapsrc/components/blocks/wrappers/__snapshots__/ConditionalChildrenLanguageDisplay.test.js.snapis excluded by!**/*.snap
📒 Files selected for processing (13)
data/yaml/page-furniture/footerBottomMenu.yaml(1 hunks)data/yaml/page-furniture/footerMenu.yaml(0 hunks)src/components/Footer/Footer.tsx(1 hunks)src/components/Footer/FooterBottomNav.tsx(0 hunks)src/components/Footer/FooterStatus.tsx(3 hunks)src/components/Footer/FooterTopNav.tsx(0 hunks)src/components/Footer/FooterTopNav/FooterLogo.tsx(0 hunks)src/components/Footer/FooterTopNav/FooterMenu/FooterMenu.tsx(0 hunks)src/components/Footer/FooterTopNav/FooterMenu/FooterMenuContainer.tsx(0 hunks)src/components/Footer/FooterTopNav/FooterSocial/FooterSocialMenu.tsx(0 hunks)src/components/Footer/FooterTopNav/FooterSocial/FooterSocialMenuIcons.tsx(0 hunks)src/components/Footer/data.ts(1 hunks)src/external-scripts/index.ts(1 hunks)
💤 Files with no reviewable changes (8)
- src/components/Footer/FooterTopNav/FooterSocial/FooterSocialMenuIcons.tsx
- src/components/Footer/FooterBottomNav.tsx
- src/components/Footer/FooterTopNav/FooterLogo.tsx
- data/yaml/page-furniture/footerMenu.yaml
- src/components/Footer/FooterTopNav/FooterMenu/FooterMenuContainer.tsx
- src/components/Footer/FooterTopNav.tsx
- src/components/Footer/FooterTopNav/FooterSocial/FooterSocialMenu.tsx
- src/components/Footer/FooterTopNav/FooterMenu/FooterMenu.tsx
✅ Files skipped from review due to trivial changes (1)
- src/external-scripts/index.ts
🔇 Additional comments (2)
src/components/Footer/Footer.tsx (1)
45-71: Footer layout updated appropriately
The footer layout has been successfully updated to integrate the new FooterStatus component and reorganize social links and bottom links as intended. The use of flexbox and responsive classes enhances the footer's responsiveness across different screen sizes.
src/components/Footer/data.ts (1)
6-6: Verify the availability of 'icon-social-x' in the icon library
Ensure that the icon named 'icon-social-x' exists in the icon library so that the X (formerly Twitter) social link displays correctly. If the icon is not available, it will result in a missing icon or error.
Run the following script to check for the existence of 'icon-social-x':
aralovelace
force-pushed
the
WEB-4100_Footer
branch
2 times, most recently
from
a323693 to
9412280
Compare
aralovelace
force-pushed
the
WEB-4100_Footer
branch
2 times, most recently
from
e429fd2 to
0e59008
Compare
jamiehenson
force-pushed
the
web-4082-docs-nav-redesign
branch
from
773642f to
2382ebf
Compare
aralovelace
force-pushed
the
WEB-4100_Footer
branch
from
976d957 to
24175de
Compare
Bumps [micromatch](https://github.com/micromatch/micromatch) from 4.0.7 to 4.0.8. - [Release notes](https://github.com/micromatch/micromatch/releases) - [Changelog](https://github.com/micromatch/micromatch/blob/master/CHANGELOG.md) - [Commits](micromatch/micromatch@4.0.7...4.0.8) --- updated-dependencies: - dependency-name: micromatch dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
chore: tidy up bar styling fix: use Gatsby-supported window object and generate snapshots fix: fix label returns in languageLabel helper chore: remove LanguageDropdownSelector fix: populate github edit link on right sidebar
chore: update package with added icons fix: CoderrabitAI feedback, change a insted of Link and key should be label
aralovelace
force-pushed
the
WEB-4100_Footer
branch
from
24175de to
f5030ca
Compare
aralovelace
changed the base branch from
main
to
web-3926-sidebar-refactoring
aralovelace
force-pushed
the
WEB-4100_Footer
branch
from
f5030ca to
188df65
Compare
Description
WEB-4100 Footer redesign - this view only suits for layout that has left side bar.
This is just the first phase, things left to do is for the footer to display correctly for different layouts, which needed to be done once the layout component has been refactored.
Removed a lot of components and just add them in one Footer component
This pull request includes significant updates to the footer component of the website, involving restructuring and refactoring for better organization and maintainability. The changes include updating the footer menu items, removing unused components, and introducing new ones.
Footer Component Updates:
data/yaml/page-furniture/footerBottomMenu.yamlto include new links and positions.FooterMenustructure fromdata/yaml/page-furniture/footerMenu.yaml, simplifying the footer navigation.src/components/Footer/Footer.tsxto integrate new footer layout and functionalities, including the introduction ofFooterStatusand dynamic link display based on position.Component Removal and Refactoring:
FooterBottomNavcomponent and its references, consolidating its functionality into the mainFootercomponent.FooterTopNavand its related components (FooterLogo,FooterMenu,FooterMenuContainer,FooterSocialMenu,FooterSocialMenuIcons) to streamline the footer structure. [1] [2] [3] [4] [5] [6]Other Changes:
FooterStatuscomponent for better clarity and integration within the new footer structure. [1] [2] [3]src/components/Footer/data.tsto include new social media platforms and update existing ones.src/external-scripts/index.tsfor better modularity.Review
Instructions on how to review the PR.
Summary by CodeRabbit
New Features
FooterStatuscomponent for enhanced footer layout.Bug Fixes
Chores