-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chat: Clarify the message listener input. #2332
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
In chat, the object passed to a listener is called the EventPayload, this contains both a type (describes the event, message.created..) and a message (contains the actual chat message). We should be clear here in the docs too.
dd2e8ee
to
f7208b5
Compare
I think we perhaps need some context around this, e.g. when would I use If we believe that's an important distinction to make, then I think we should also update the example message payload to show both, or add it as a separate example relating to the first question (i.e. when would I use it). |
@m-hulbert So, event.type should be used for listeners as listeners receive event payloads. |
Description
In chat, the object passed to a listener is called the MessageEventPayload, this contains both a type (describes the event, message.created..) and a message (contains the actual chat message).
We should be clear here in the docs too.