-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fillup missing vulnerabilities summary #1767
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Tushar Goel <[email protected]>
9557b88
to
f4140cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are some feedback.
vulnerabilities/pipelines/fill_vulnerability_summary_pipeline.py
Outdated
Show resolved
Hide resolved
matching_advisories = nvd_importer_advisories.filter(Q(aliases__contains=alias)) | ||
|
||
if matching_advisories.exists(): | ||
# Take the first matching advisory with a summary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Take the first matching advisory with a summary | |
# Take the first matching advisory with a summary. | |
# NVD advisories only have one alias, always a CVE |
vulnerabilities/pipelines/fill_vulnerability_summary_pipeline.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Tushar Goel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @TG1999, few nits for your consideration.
vulnerabilities/pipelines/fill_vulnerability_summary_pipeline.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Tushar Goel <[email protected]>
Reference: #859