Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fillup missing vulnerabilities summary #1767

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

TG1999
Copy link
Contributor

@TG1999 TG1999 commented Jan 29, 2025

Reference: #859

Signed-off-by: Tushar Goel <[email protected]>
@TG1999 TG1999 force-pushed the missing_summaries_pipeline branch from 9557b88 to f4140cd Compare February 11, 2025 14:09
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some feedback.

matching_advisories = nvd_importer_advisories.filter(Q(aliases__contains=alias))

if matching_advisories.exists():
# Take the first matching advisory with a summary
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Take the first matching advisory with a summary
# Take the first matching advisory with a summary.
# NVD advisories only have one alias, always a CVE

Signed-off-by: Tushar Goel <[email protected]>
Copy link
Member

@keshav-space keshav-space left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @TG1999, few nits for your consideration.

Signed-off-by: Tushar Goel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants