Skip to content

Conversation

salihozkara
Copy link
Member

@salihozkara salihozkara commented May 16, 2025

Resolves https://github.com/volosoft/vs-internal/issues/6542
From now on, only the admin will be able to generate PDFs. If a PDF exists, a download option will be shown in the UI

@salihozkara salihozkara requested a review from maliming May 20, 2025 05:21
Copy link
Contributor

@oykuermann oykuermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • We can change 'in' with 'to' : PDF generation has started. Once completed, you can check if the file has been added to the PDF files section.
  • We don't need to write 'PDF generation started' two times.
image
  • We can't see PDF file before reopening the modal:
screen-capture.-.2025-05-20T114448.491.webm

Copy link
Contributor

@oykuermann oykuermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approved, but please do not merge until vs-internal part is solved:
image

@maliming maliming requested a review from oykuermann May 22, 2025 00:09
Copy link

codecov bot commented Jun 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.23%. Comparing base (4a329d1) to head (ff66c09).
Report is 522 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #22922      +/-   ##
==========================================
- Coverage   52.30%   52.23%   -0.08%     
==========================================
  Files        3204     3208       +4     
  Lines      103280   103569     +289     
  Branches     7855     7878      +23     
==========================================
+ Hits        54017    54095      +78     
- Misses      47620    47829     +209     
- Partials     1643     1645       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@salihozkara salihozkara requested a review from maliming June 13, 2025 15:25
@hikalkan hikalkan merged commit 717598a into dev Jun 17, 2025
3 of 4 checks passed
@hikalkan hikalkan deleted the issue-6542 branch June 17, 2025 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants