-
Notifications
You must be signed in to change notification settings - Fork 43
Remove begin/end methods to simplify the implementation #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
conflict, needs to be resolved. Please note that HID.cpp is a core Arduino module |
86a7cab
to
bbe7da3
Compare
I've now rebased the PR to resolve the conflict.
Does this mean that you want me to first submit a PR for updating the HID implementation in https://github.com/arduino/ArduinoCore-avr with the same change? |
I've proposed the same |
bbe7da3
to
5d86f78
Compare
Hi Fredrik, what I mean is - it makes no sense to refactor HID.cpp in this repo because this is a core Arduino module. I only took it here because there was no other option to override the implementation of the HID protocol in the official Arduino library. The intent was to make only necessary changes and ensure they are mergeable with the original. |
a8e26c1
to
86d976a
Compare
86d976a
to
8245f61
Compare
Proposal to simplify the implementation by removing dead code.
Proposal to simplify the implementation by removing dead code.
Proposal to simplify the implementation by avoiding the need for manually calling begin() before using HIDPowerDevice_.
8245f61
to
a6816b0
Compare
Proposal to simplify the implementation by avoiding the need for manually calling
begin()
before usingHIDPowerDevice_
.