Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements of assertDictContainsSubset method. #319

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Minor improvements of assertDictContainsSubset method. #319

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions absl/testing/absltest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1659,21 +1659,17 @@ def CheckEqual(a, b):
def assertDictContainsSubset(
self, subset: Mapping[Any, Any], dictionary: Mapping[Any, Any], msg=None
):
"""Raises AssertionError if dictionary is not a superset of subset.
"""Raises AssertionError if "dictionary" is not a superset of "subset".

Args:
subset: A dict, the expected subset of the `dictionary`.
subset: A dict, the expected subset of the "dictionary".
dictionary: A dict, the actual value.
msg: An optional str, the associated message.

Raises:
AssertionError: if dictionary is not a superset of subset.
AssertionError: if "dictionary" is not a superset of "subset".
"""
if not isinstance(subset, dict):
subset = dict(subset)
if not isinstance(dictionary, dict):
dictionary = dict(dictionary)
self.assertDictEqual(dictionary, {**dictionary, **subset}, msg)
self.assertDictEqual({**dictionary}, {**dictionary, **subset}, msg)

def assertDictEqual(self, a, b, msg=None):
"""Raises AssertionError if a and b are not equal dictionaries.
Expand Down
Loading