Skip to content

Conversation

@felixgateru
Copy link
Contributor

What type of PR is this?

This is a feature as it adds support for private and public metadata for Users and Clients

What does this do?

This pr:

  • adds a database column for public metadata and subsequent changes to Users and Clients structs

Which issue(s) does this PR fix/relate to?

Have you included tests for your changes?

Yes, tests have been updated.

Did you document any new/modified feature?

Yes, api docs have been updated for the changes

Notes

@codecov
Copy link

codecov bot commented Sep 25, 2025

Codecov Report

❌ Patch coverage is 72.39819% with 61 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.99%. Comparing base (0fe5a6d) to head (e8269da).

Files with missing lines Patch % Lines
users/api/grpc/server.go 0.00% 21 Missing ⚠️
users/api/grpc/client.go 0.00% 15 Missing ⚠️
users/postgres/users.go 89.70% 4 Missing and 3 partials ⚠️
api/grpc/users/v1/users.pb.go 0.00% 6 Missing ⚠️
clients/events/events.go 0.00% 6 Missing ⚠️
clients/postgres/clients.go 89.47% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3155      +/-   ##
==========================================
- Coverage   50.82%   46.99%   -3.84%     
==========================================
  Files         175      130      -45     
  Lines       25891    21305    -4586     
==========================================
- Hits        13159    10012    -3147     
+ Misses      12010    10732    -1278     
+ Partials      722      561     -161     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@felixgateru felixgateru marked this pull request as ready for review September 29, 2025 08:45
@felixgateru felixgateru requested a review from a team as a code owner September 29, 2025 08:45
@felixgateru felixgateru force-pushed the smq3108-metadata branch 3 times, most recently from 3a95df7 to 37a317c Compare December 4, 2025 07:26
Copy link
Collaborator

@dborovcanin dborovcanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To keep it backward compatible and not break API, let's consider our Metadata private, and just add public one. I.e. we have metadata and publicMetadata fields. Private ones should not be visible even to superadmin, probably, but for now - let's just add public meta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add public metadata to Users and Clients

2 participants