SMQ-3108 - Add support for public and private metadata for users and clients #3155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3155 +/- ##
===========================================
+ Coverage 53.21% 79.16% +25.95%
===========================================
Files 312 109 -203
Lines 32706 13203 -19503
===========================================
- Hits 17404 10452 -6952
+ Misses 14234 2133 -12101
+ Partials 1068 618 -450 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
felixgateru
force-pushed
the
smq3108-metadata
branch
from
9fefd43 to
72c75d5
Compare
felixgateru
force-pushed
the
smq3108-metadata
branch
from
72c75d5 to
bd9dfdd
Compare
felixgateru
force-pushed
the
smq3108-metadata
branch
3 times, most recently
from
3a95df7 to
37a317c
Compare
felixgateru
force-pushed
the
smq3108-metadata
branch
from
37a317c to
e8269da
Compare
dborovcanin
requested changes
Dec 23, 2025
Collaborator
dborovcanin
left a comment
dborovcanin
left a comment
There was a problem hiding this comment.
To keep it backward compatible and not break API, let's consider our Metadata private, and just add public one. I.e. we have metadata and publicMetadata fields. Private ones should not be visible even to superadmin, probably, but for now - let's just add public meta.
felixgateru
force-pushed
the
smq3108-metadata
branch
2 times, most recently
from
d31dca6 to
7253696
Compare
Collaborator
|
@felixgateru Please resolve conflicts. |
felixgateru
force-pushed
the
smq3108-metadata
branch
from
7253696 to
7c51ae9
Compare
arvindh123
requested changes
Jan 19, 2026
Comment on lines
+92
to
+96
| if uce.PublicMetadata != nil { | ||
| val["public_metadata"] = uce.PublicMetadata |
Contributor
There was a problem hiding this comment.
Why we are not emitting metadata ?
arvindh123
requested changes
Jan 19, 2026
Comment on lines
93
to
96
| meta, ok := data["public_metadata"].(map[string]any) | ||
| if ok { | ||
| c.Metadata = meta | ||
| c.PublicMetadata = meta | ||
| } |
Contributor
There was a problem hiding this comment.
Missing metadata in decoding
arvindh123
previously approved these changes
Jan 19, 2026
dborovcanin
requested changes
Jan 21, 2026
| logType outputLog | ||
| }{ | ||
| { | ||
| desc: "update client name and public metadata successfully", |
Collaborator
There was a problem hiding this comment.
Add a test case for updating public metadata only (also add unhappy flow for it).
| err: nil, | ||
| }, | ||
| { | ||
| desc: "update public metadata successfully as normal user", |
Collaborator
There was a problem hiding this comment.
Add unhappy flow also (invalid format).
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
felixgateru
force-pushed
the
smq3108-metadata
branch
from
aa33db2 to
d48fc9b
Compare
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a feature as it adds support for private and public metadata for Users and Clients
What does this do?
This pr:
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
Yes, tests have been updated.
Did you document any new/modified feature?
Yes, api docs have been updated for the changes
Notes