Fix SYSTEMC_UNITY_BUILD for static builds with custom main() #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building SystemC as a static library with SYSTEMC_UNITY_BUILD=ON, linking fails if the user defines their own main() (e.g., in a test) because the internal sc_main.cpp object is included in the unity build and conflicts with the custom main(). This patch excludes sc_main.cpp from unity builds to restore expected behavior for static linking scenarios with external main() definitions. Signed-off-by: Ruben Brandhofer <[email protected]>
lmailletcontoz
merged commit de72c4f
into
accellera-official:main
50 of 98 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building SystemC as a static library with SYSTEMC_UNITY_BUILD=ON, linking fails if the user defines their own main() (e.g., in a test) because the internal sc_main.cpp object is included in the unity build and conflicts with the custom main().
This patch excludes sc_main.cpp from unity builds to restore expected behavior for static linking scenarios with external main() definitions.