Codex/add mobile bottom safe inset for action sheets - #151
Merged
Chucks1093 merged 6 commits intoApr 25, 2026
Merged
Conversation
…ck-for-reduced-motion Add reduced-motion fallback for creator skeleton shimmer
…text-for-claims Add standardized claim-action disabled-reason helper text
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add mobile-safe bottom inset padding to shared DialogContent by adding pb-[calc(1.5rem+env(safe-area-inset-bottom))] and reset desktop spacing with sm:pb-6 in src/components/ui/dialog.tsx.
Add a focused unit test src/components/ui/dialog.test.tsx that renders Dialog/DialogContent and asserts the new mobile class and the desktop reset class are present.
Change is scoped to the dialog component and a single test file with no unrelated file churn.
Testing
Ran pnpm test src/components/ui/dialog.test.tsx, which passed (1 test file, 1 test passed).
Ran pnpm lint, which completed successfully.
pnpm lintpnpm buildChecklist
close #132