Skip to content

feat: add Esc keyboard hint support for dialogs - #237

Merged
Chucks1093 merged 1 commit into
accesslayerorg:mainfrom
opascal221-design:feat/close-223-224-227-229
Apr 28, 2026
Merged

feat: add Esc keyboard hint support for dialogs#237
Chucks1093 merged 1 commit into
accesslayerorg:mainfrom
opascal221-design:feat/close-223-224-227-229

Conversation

@opascal221-design

Copy link
Copy Markdown

Summary

  • add a reusable keyboard hint (Esc to close) inside dialog content for open dialog contexts
  • render hint as an absolute, non-interactive overlay so layout flow is unchanged
  • add showEscapeHint opt-out prop on DialogContent for contexts where Escape dismissal is intentionally blocked
  • wire opt-out in guarded dialog states (TradeDialog while submitting, PendingTxModal while blocked/loading)
  • add focused unit tests covering default visible hint and disabled-hint behavior

Validation

  • npm test -- src/components/ui/dialog.test.tsx (fails locally: vitest not found in this clone environment)

Closes #223
Closes #224
Closes #227
Closes #229

@drips-wave

drips-wave Bot commented Apr 28, 2026

Copy link
Copy Markdown

@opascal221-design Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@Chucks1093
Chucks1093 merged commit 1311a74 into accesslayerorg:main Apr 28, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants