feat: Add creator card subtitle clamp helper - #569
Merged
Conversation
|
@Uche44 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added creatorCardSubtitleClampClass helper function and DEFAULT_CREATOR_CARD_SUBTITLE_MAX_LINES constant in lineClamp.utils.ts.
Applied creatorCardSubtitleClampClass to TrendingCreatorCard.tsx description paragraph for consistent subtitle line clamping.
Updated CreatorBio.tsx to use creatorCardSubtitleClampClass when clamping card variant bios.
Added unit test suite in lineClamp.utils.test.ts covering default line count, custom line counts, out-of-bounds capping, and invalid inputs.
Updated TrendingCreatorCard.integration.test.tsx with an integration test verifying that the subtitle line-clamp utility class is applied to card description elements.
Closes Add creator card subtitle clamp helper #205
Testing
pnpm lintpnpm buildChecklist
Test screenshots
