implemented - #610
Merged
Merged
Conversation
|
@wandooadzer-cmyk Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
File:
src/hooks/__tests__/useInfiniteScroll.test.tsxTests:
onLoadMoreis called when the sentinel element intersectsonLoadMoreis NOT called when the element is out of viewdisconnect()is called when the component unmountsenabled: false— confirms no observer is created when the hook is disabledhasMore: false— bonus: also covers thehasMoreguardThe mock uses a class-based
IntersectionObserverreplacement that captures callbacks, allowing tests to manually simulate intersection events. The root cause of the initial failures was a JSX gotcha: bare attribute shorthandonLoadMorewas interpreted asonLoadMore={true}, which broke the ref.Testing
pnpm lintpnpm buildChecklist
Closes Add unit tests for the infinite scroll Intersection Observer hook #586
Closes Add integration test for wallet disconnect clearing all cached query data #587
Closes Add structured log for client-side JavaScript errors via window.onerror handler #588
Closes Add integration test for wallet address display truncating correctly in the header #589