Skip to content

test(wallet): cover creator 404, activity ordering, holdings total updates, and disconnect session logging - #664

Merged
Chucks1093 merged 1 commit into
accesslayerorg:devfrom
Calebux:wave-656-658-659-660-accesslayer
Jul 27, 2026
Merged

test(wallet): cover creator 404, activity ordering, holdings total updates, and disconnect session logging#664
Chucks1093 merged 1 commit into
accesslayerorg:devfrom
Calebux:wave-656-658-659-660-accesslayer

Conversation

@Calebux

@Calebux Calebux commented Jul 27, 2026

Copy link
Copy Markdown

Closes #656
Closes #658
Closes #659
Closes #660

Summary

This PR covers four related marketplace and wallet reliability issues:

  • adds a distinct creator not-found state for 404 creator profile responses
  • adds integration coverage for wallet activity ordering and Buy/Sell labels
  • adds structured debug logging for wallet disconnect session duration
  • adds integration coverage for holdings grand total updates after a confirmed buy

What changed

#656 Creator profile 404 state

  • added canonical /creator/:id route support while keeping existing creator detail routing
  • preserved API 404 errors in the creator detail flow instead of collapsing them into a generic failure
  • updated the creator page error boundary to render a dedicated not-found state with a back-to-creators action
  • added an integration test asserting:
    • not-found state is shown for a 404 response
    • loading skeleton is gone after resolution
    • generic error copy is not shown
    • back-to-creators navigation is present

#658 Wallet activity feed ordering

  • updated TransactionHistory to sort entries in descending timestamp order before rendering
  • added an integration test asserting:
    • trades render in reverse chronological order
    • Buy and Sell labels are correct
    • creator handles and trade amounts are visible for each entry

#659 Wallet disconnect session logging

  • added a reusable wallet disconnect log helper
  • record connect time while the wallet session is active
  • emit a structured debug log on disconnect with:
    • truncated_address
    • session_duration_ms
    • disconnected_at
  • ensured the full wallet address is not logged
  • ensured the disconnect log is suppressed in the test environment
  • added unit/integration coverage for the log payload and environment guard

#660 Holdings grand total live update

  • added an integration test that simulates a confirmed buy updating the holdings cache
  • asserted the holdings total updates from 500 XLM to 700 XLM without reload
  • asserted the new holding entry becomes visible alongside the existing one

Validation

  • pnpm vitest run src/pages/__tests__/CreatorDetailPage.integration.test.tsx src/components/common/__tests__/TransactionHistory.order.integration.test.tsx src/components/common/__tests__/ConnectWalletButton.test.tsx src/lib/__tests__/walletSessionLog.test.ts src/pages/__tests__/LandingPage.holdingsGrandTotal.integration.test.tsx --reporter=dot
  • pnpm lint
  • pnpm build

@drips-wave

drips-wave Bot commented Jul 27, 2026

Copy link
Copy Markdown

@Calebux Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@Chucks1093
Chucks1093 merged commit a346ed8 into accesslayerorg:dev Jul 27, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment