Add integration tests for held_since per-holder timestamp in creator holders endpoint - #498
Merged
Chucks1093 merged 2 commits intoJun 27, 2026
Conversation
…tamp per holder Verifies that GET /creators/:id/holders returns held_since equal to the KeyOwnership.createdAt of each wallet's first buy, including: - Three wallets with distinct first-buy timestamps each show their own - A wallet that bought twice shows the earliest buy timestamp, not the latest - held_since values serialise to ISO 8601 format - sort=held_since passes the correct query parameter to the service Closes accesslayerorg#493
|
@10xwhoman Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
creator-holders-held-since.integration.test.tswith 6 tests for theGET /creators/:id/holdersendpointheld_sincereflects their first-buycreatedAttimestamp (not updated on subsequent buys)sort=held_sincequery paramTest plan
npm test -- creator-holders-held-sincepasses (6 tests)held_since, ISO 8601 format, 3-wallet distinct timestamps, sort param forwardingCloses #493