feat: add structured logging for alert registration and deletion - #527
Merged
Chucks1093 merged 1 commit intoJun 27, 2026
Merged
Conversation
|
@wagmiiii Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #505
Summary
Adds structured observability logs when price alerts are successfully registered or manually cancelled. This allows monitoring alert activity without querying the database and provides debugging context for unexpectedly fired alerts.
What Changed
logger.infotocreateAlertemittingalert_id,creator_id,direction,target_price, andregistered_at.logger.infotodeleteAlertemittingalert_id,creator_id, andcancelled_at.maskWalletAddresshelper inside the alert service to log wallet addresses safely.alert.service.test.tsto mocklogger.infoand assert payload structures.Key Design Decisions
wallet_addressexplicitly in the log payloads. Because alerts operate on behalf of a wallet, auditing who acted is highly logical and provides useful context without leaking full addresses.toNumberhelper inside the service to safely serialise PrismaDecimalinstances for the logger.Acceptance Criteria
Test Output & Coverage
alert.service.test.tscallback_url.Security Note
PII is completely isolated.
callback_urlis omitted entirely from these logs, and thewallet_addressis strictly masked to its first and last 4 characters (GAAA***AAAA) before passing to the logger payload.Follow-ups
maskAddressinownership.service.tsandwallet.utils.ts).