Add Cross-Ledger Boundary Tests for 24-Hour Volume Calculation - #651
Merged
Chucks1093 merged 1 commit intoJul 26, 2026
Merged
Conversation
|
@Damilorlar Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
##closed #649
Why this matters
The 24-hour volume helper should accurately calculate trading volume within a rolling 24-hour window, regardless of ledger boundaries. Trades occurring across consecutive ledgers (such as the last ledger of one day and the first ledger of the next) must be evaluated solely by their timestamps to ensure consistent and correct volume calculations.
Scope
Expand the unit test suite to validate volume calculations across ledger boundaries by:
Seeding trades with timestamps at:
23 hours 59 minutes ago
Exactly 24 hours ago (inclusive boundary)
24 hours 1 minute ago
1 hour ago
Verifying that trades occurring 23h 59m ago and 1h ago are included in the rolling 24-hour window.
Confirming that the trade occurring exactly 24 hours ago is also included, validating the inclusive boundary behavior.
Ensuring the trade occurring 24 hours 1 minute ago is excluded from the calculation.
Asserting that the returned 24-hour volume equals the sum of only the included trades.
Acceptance Criteria
Trade at 23h 59m ago is included in the calculation.
Trade at the exact 24-hour boundary is included.
Trade at 24h 1m ago is excluded.
The calculated 24-hour volume equals the total value of the included trades only.