Skip to content

Add Cross-Ledger Boundary Tests for 24-Hour Volume Calculation - #651

Merged
Chucks1093 merged 1 commit into
accesslayerorg:mainfrom
Damilorlar:feat/24h-volume-cross-boundary-test
Jul 26, 2026
Merged

Add Cross-Ledger Boundary Tests for 24-Hour Volume Calculation#651
Chucks1093 merged 1 commit into
accesslayerorg:mainfrom
Damilorlar:feat/24h-volume-cross-boundary-test

Conversation

@Damilorlar

Copy link
Copy Markdown
Contributor

##closed #649

Why this matters
The 24-hour volume helper should accurately calculate trading volume within a rolling 24-hour window, regardless of ledger boundaries. Trades occurring across consecutive ledgers (such as the last ledger of one day and the first ledger of the next) must be evaluated solely by their timestamps to ensure consistent and correct volume calculations.

Scope
Expand the unit test suite to validate volume calculations across ledger boundaries by:
Seeding trades with timestamps at:
23 hours 59 minutes ago
Exactly 24 hours ago (inclusive boundary)
24 hours 1 minute ago
1 hour ago
Verifying that trades occurring 23h 59m ago and 1h ago are included in the rolling 24-hour window.
Confirming that the trade occurring exactly 24 hours ago is also included, validating the inclusive boundary behavior.
Ensuring the trade occurring 24 hours 1 minute ago is excluded from the calculation.
Asserting that the returned 24-hour volume equals the sum of only the included trades.
Acceptance Criteria
Trade at 23h 59m ago is included in the calculation.
Trade at the exact 24-hour boundary is included.
Trade at 24h 1m ago is excluded.
The calculated 24-hour volume equals the total value of the included trades only.

@drips-wave

drips-wave Bot commented Jul 25, 2026

Copy link
Copy Markdown

@Damilorlar Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@Chucks1093
Chucks1093 merged commit 5a795cf into accesslayerorg:main Jul 26, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add unit tests for compute24hVolume helper returning correct sum when trades span a ledger boundary

2 participants