Add test coverage: wallet activity ordering, price snapshot logging, address validation, pagination edges - #653
Merged
Chucks1093 merged 1 commit intoJul 26, 2026
Conversation
…g, address validation, and pagination edge cases - Order wallet activity feed test by ledger descending and verify pagination (accesslayerorg#637) - Emit correct debug log fields (creator_id, new_price, previous_price, ledger, ingested_at) on price snapshot writes (accesslayerorg#636) - Cover adjacent invalid Stellar address formats: lowercase, invalid base32 char, leading/trailing whitespace (accesslayerorg#638) - Cover buildPaginatedResponse boundary cases for limit of 1 (accesslayerorg#635) Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
@Abidoyesimze Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
typecorrectness, and that the pagination limit/cursor are respected.upsertPriceSnapshotand fix the debug-level log emitted after each successful price snapshot write to use the correct fields (creator_id,new_price,previous_price,ledger,ingested_at), withprevious_pricenull on the first snapshot and no log on a failed write.0), leading whitespace, and trailing newline, plus a regression check on the existing valid address.buildPaginatedResponseboundary tests for a limit of 1 (2 results →has_more: true; 1 result →has_more: false).Closes #637
Closes #636
Closes #638
Closes #635
Test plan
npx jest src/modules/wallets/__tests__/wallet-activity-ledger-order.integration.test.tsnpx jest src/modules/indexer/price-snapshot-debug-log.unit.test.tsnpx jest src/modules/indexer/indexer-pipeline.integration.test.tsnpx jest src/modules/wallet/__tests__/wallet.utils.test.tsnpx jest src/utils/test/pagination.utils.test.tsnpx tsc --noEmitandnpx eslintclean on all touched files🤖 Generated with Claude Code