Skip to content

test: add integration tests for webhook 404 responses on non-existent IDs - #655

Merged
Chucks1093 merged 1 commit into
accesslayerorg:mainfrom
abrcrmb:test/webhook-404-integration
Jul 26, 2026
Merged

test: add integration tests for webhook 404 responses on non-existent IDs#655
Chucks1093 merged 1 commit into
accesslayerorg:mainfrom
abrcrmb:test/webhook-404-integration

Conversation

@abrcrmb

@abrcrmb abrcrmb commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

Closes #647


Add GET detail and PATCH update endpoints for webhooks, and integration
tests that confirm all three endpoints (GET, PATCH, DELETE) return 404
with a descriptive error body when a non-existent webhook ID is targeted.

  • Add getWebhook() and updateWebhook() service functions
  • Add getWebhookHandler and updateWebhookHandler controller handlers
  • Add UpdateWebhookSchema for PATCH request validation
  • Add GET and PATCH routes under /:id/webhooks/:webhookId
  • Add integration tests verifying 404 status and error body shape
  • Update existing DELETE 404 test to verify error body shape

… IDs

Add GET detail and PATCH update endpoints for webhooks, and integration
tests that confirm all three endpoints (GET, PATCH, DELETE) return 404
with a descriptive error body when a non-existent webhook ID is targeted.

- Add getWebhook() and updateWebhook() service functions
- Add getWebhookHandler and updateWebhookHandler controller handlers
- Add UpdateWebhookSchema for PATCH request validation
- Add GET and PATCH routes under /:id/webhooks/:webhookId
- Add integration tests verifying 404 status and error body shape
- Update existing DELETE 404 test to verify error body shape
@drips-wave

drips-wave Bot commented Jul 26, 2026

Copy link
Copy Markdown

@abrcrmb Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@Chucks1093
Chucks1093 merged commit 3437507 into accesslayerorg:main Jul 26, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add integration test for webhook endpoint returning 404 when webhook ID does not exist

2 participants