Skip to content

test: cover holdings without price snapshot - #659

Merged
Chucks1093 merged 1 commit into
accesslayerorg:mainfrom
bamiebot-maker:test/holdings-missing-price-snapshot
Jul 26, 2026
Merged

test: cover holdings without price snapshot#659
Chucks1093 merged 1 commit into
accesslayerorg:mainfrom
bamiebot-maker:test/holdings-missing-price-snapshot

Conversation

@bamiebot-maker

Copy link
Copy Markdown
Contributor

Summary

  • return total_value: "0" when a holding's creator has no price snapshot
  • preserve the holding and its key_count quantity
  • add service-level missing-snapshot coverage and endpoint/controller integration coverage
  • verify the endpoint responds successfully without forwarding an error

Verification

  • pnpm test -- --runInBand src/modules/wallets/wallet-holdings-price-snapshot.integration.test.ts src/modules/wallets/__tests__/wallet-holdings.integration.test.ts ? 13 passed
  • pnpm lint ? passed
  • pnpm build ? passed
  • pnpm exec prettier --check for all changed files ? passed after formatting

The repository-wide Jest invocation exceeded 10 minutes locally; the focused suites completed cleanly.

Closes #634

@drips-wave

drips-wave Bot commented Jul 26, 2026

Copy link
Copy Markdown

@bamiebot-maker Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@Chucks1093
Chucks1093 merged commit 0e3a898 into accesslayerorg:main Jul 26, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add integration test for holdings endpoint returning correct total_value when price snapshot is missing for a creator

2 participants