#664 Add structured log for each price alert delivery attempt with threshold, current price, and delivery status - #672
Merged
Chucks1093 merged 2 commits intoJul 27, 2026
Conversation
…ttempt with threshold, current price, and delivery status
|
@jotel-dev Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds structured debug-level logging for each price alert webhook delivery attempt to improve operational observability. Previously, no log was emitted when a price alert delivery was attempted, making it difficult for operators to trace alert delivery activity or diagnose missed/duplicate deliveries without querying the database.
The implementation adds a debug log entry immediately after each delivery attempt completes (both successful and failed), containing:
alert_id: Unique identifier of the price alert
creator_id: Creator whose key price triggered the alert
threshold: Target price threshold configured for the alert
triggered_price: Actual price that triggered the alert
delivery_status: Outcome of the delivery attempt ("success" or "failed")
attempted_at: Timestamp when the delivery attempt was made
The callback URL is intentionally excluded from the debug log to avoid exposing sensitive endpoint information. Existing warn/error logs with masked URLs remain for debugging delivery failures.
Testing
pnpm lint
pnpm build
pnpm exec prisma generate when schema or generated types changed
Checklist
Linked issue or backlog item (#664)
No secrets or live credentials added
Docs updated if setup or env changed
Change is scoped to one problem
closes #664