test(holders): add integration test for empty key holders list endpoint - #677
Merged
Chucks1093 merged 1 commit intoJul 28, 2026
Conversation
|
@abimbolaalabi Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds a database-backed integration test that verifies the
GET /api/v1/creators/:id/holdersendpoint returns a 200 status with an empty items array when a creator exists but has no key holders, rather than a 404 or error.Related Issue
Closes #662
Changes
🧪 Integration Test
src/__tests__/integration/creator-holders-empty-list.test.ts— seeds a creator with noKeyOwnershiprecords and asserts:200itemsis an empty arraymeta.totalis0andmeta.hasMoreisfalseVerification Results
The controller logic (
src/modules/creators/creator-holders.controller.ts) already returns 200 with{ items: [], meta: { total: 0, hasMore: false } }when no holders exist — this test simply adds coverage for that code path end-to-end through the database.itemsis an empty arrayhas_moreis false