Skip to content

fix(creator): guard empty slug params consistently - #98

Merged
Chucks1093 merged 1 commit into
accesslayerorg:mainfrom
shoaib050326:codex/issue-80-empty-slug-guard
Mar 29, 2026
Merged

fix(creator): guard empty slug params consistently#98
Chucks1093 merged 1 commit into
accesslayerorg:mainfrom
shoaib050326:codex/issue-80-empty-slug-guard

Conversation

@shoaib050326

@shoaib050326 shoaib050326 commented Mar 29, 2026

Copy link
Copy Markdown

Summary

  • normalize empty and whitespace-only creator slug params before deeper schema handling
  • return the same Creator ID is required validation error for empty-like creator slug input
  • add a focused schema regression test for empty, whitespace-only, and valid creator IDs

Root Cause

The creator slug preprocessing only treated the exact empty string as missing input. Whitespace-only route params were left to deeper validation, and exact empty strings surfaced a generic Zod Required error instead of the creator-specific validation message.

Testing

  • pnpm exec ts-node src/modules/creator/creator-profile.schemas.test.ts
  • pnpm exec ts-node src/modules/creator/creator-list-page.guard.test.ts

Closes #80

@shoaib050326 shoaib050326 changed the title [codex] fix creator empty slug guard fix(creator): guard empty slug params consistently Mar 29, 2026
@drips-wave

drips-wave Bot commented Mar 29, 2026

Copy link
Copy Markdown

@shoaib050326 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@shoaib050326
shoaib050326 marked this pull request as ready for review March 29, 2026 04:05
@Chucks1093
Chucks1093 merged commit ea5d955 into accesslayerorg:main Mar 29, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add empty-slug guard for creator routes

2 participants