Merge pull request #271 from accordproject/dl-nav-headings

fix(Navigation): handle empty headings
accordproject · Feb 3, 2020 · ca3d168 · ca3d168
2 parents 1dd6e1e + 62bd6e8
commit ca3d168
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 5 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -110,4 +110,4 @@
       "<rootDir>/src/**/?(*.)(spec|test).{js,jsx,mjs}"
     ]
   }
-}
+}
diff --git a/src/Navigation/actions.js b/src/Navigation/actions.js
@@ -1,6 +1,5 @@
-const truncateHeading = (heading, length) => ((heading.length > length)
-  ? `${heading.substring(0, length)}...`
-  : heading);
+const truncateHeading = (heading, length) => ((heading && (heading.length > length))
+  ? `${heading.substring(0, length)}...` : heading || '');
 
 export const truncateHeader = ({ type, text }) => {
   switch (type) {

diff --git a/src/Navigation/generators.js b/src/Navigation/generators.js
@@ -18,6 +18,8 @@ export const headerGenerator = (props) => {
 
   return headers.map((header) => {
     const { type, key } = header;
+    const heading = truncateHeader(header);
+    if (!heading) return null;
     switch (type) {
       case 'clause':
         return (