-
Notifications
You must be signed in to change notification settings - Fork 729
STR8BARZ #691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dbwoyp
wants to merge
2
commits into
ace-step:main
Choose a base branch
from
dbwoyp:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+128
−18
Open
STR8BARZ #691
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,16 @@ | ||
| """Gradio package: web UI composition for ACE-Step controls and outputs.""" | ||
| from acestep.ui.gradio.interfaces import create_gradio_interface # noqa: F401 | ||
|
|
||
| from __future__ import annotations | ||
|
|
||
| from typing import Any | ||
|
|
||
|
|
||
| def create_gradio_interface(*args: Any, **kwargs: Any) -> Any: | ||
| """Create the Gradio interface using a lazy import. | ||
|
|
||
| This keeps package imports lightweight for environments that run unit tests | ||
| without Gradio installed, while preserving the existing public facade. | ||
| """ | ||
| from acestep.ui.gradio.interfaces import create_gradio_interface as _create_gradio_interface | ||
|
|
||
| return _create_gradio_interface(*args, **kwargs) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| """Tests for lazy-import behavior in the Gradio package facade.""" | ||
|
|
||
| import importlib | ||
| import unittest | ||
|
|
||
|
|
||
| class GradioPackageInitTests(unittest.TestCase): | ||
| """Verify `acestep.ui.gradio` imports without requiring Gradio at import time.""" | ||
|
|
||
| def test_package_import_exposes_interface_factory_without_gradio_dependency(self): | ||
| """Importing package should succeed and expose the create facade callable.""" | ||
| module = importlib.import_module("acestep.ui.gradio") | ||
| self.assertTrue(callable(module.create_gradio_interface)) | ||
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| unittest.main() | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test does not enforce the "without Gradio" invariant it claims to verify.
importlib.import_modulehere runs in an environment where Gradio is installed, so the test passes even if__init__.pyeagerly imports Gradio. If the lazy-import pattern were reverted, nothing would break this test. The method name and docstring assert a property that is never actually tested.To enforce the contract, block the
gradioimport viasys.modulesbefore re-importing the module under test.🛡️ Proposed fix
📝 Committable suggestion
🤖 Prompt for AI Agents