Skip to content

Commit

Permalink
[configuration] Escape values in config module (#8901)
Browse files Browse the repository at this point in the history
PR#8759 converted the escape module to use unsafeInsert/update
to save data and prevent double escaping issues. The usages of
the textarea were audited to make sure they were properly escaped,
however the value is also displayed in the configuration module
itself. Until the module is updated from smarty to react (PR#8471),
they need to be escaped in the config module itself.

This adds escaping to the config module smarty template.
  • Loading branch information
driusan authored Sep 28, 2023
1 parent 81a76fc commit 72bd0fd
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions modules/configuration/templates/form_configuration.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,11 @@
{/function}

{function name=createTextArea}
<textarea class="form-control" rows="4" name="{$k}" {if $d eq "Yes"}disabled{/if}>{$v}</textarea>
<textarea class="form-control" rows="4" name="{$k}" {if $d eq "Yes"}disabled{/if}>{$v|escape:html}</textarea>
{/function}

{function name=createText}
<input type="text" class="form-control" name="{$k}" value="{$v}" {if $d eq "Yes"}disabled{/if}>
<input type="text" class="form-control" name="{$k}" value="{$v|escape:html}" {if $d eq "Yes"}disabled{/if}>
{/function}

{function name=createLogDropdown}
Expand Down

0 comments on commit 72bd0fd

Please sign in to comment.