-
Notifications
You must be signed in to change notification settings - Fork 1
feat(checkpoint)!: add verified scientific checkpoint manifests #587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
85fc3b3
feat(checkpoint)!: add verified scientific checkpoint manifests
acgetchell da8e80c
chore(checkpoint): address review feedback and refresh dependencies
acgetchell 5093443
Merge branch 'main' into feat/580-scientific-checkpoint-manifest
acgetchell 2b4c169
fix(tooling): synchronize isolated Cargo fixture updates (#587)
acgetchell adc6259
fix(tooling): enforce numerical and dependency update contracts
acgetchell f4d2051
refactor!: harden mutation and validation boundaries
acgetchell cae4645
fix: harden CI and rollback validation (#587)
acgetchell a023b29
test(topology): verify failure-atomic move semantics (#587)
acgetchell File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| //! Throughput evidence for scientific checkpoint manifest and wire serialization. | ||
|
|
||
| #![forbid(unsafe_code)] | ||
|
|
||
| use criterion::{Criterion, Throughput, criterion_group, criterion_main}; | ||
| use delaunay::prelude::checkpoint::DelaunayCheckpoint; | ||
| use delaunay::prelude::construction::{ | ||
| DelaunayTriangulation, DelaunayTriangulationBuilder, Vertex, | ||
| }; | ||
| use delaunay::prelude::geometry::AdaptiveKernel; | ||
| use serde_json::{from_slice, to_vec}; | ||
| use std::hint::black_box; | ||
|
|
||
| #[path = "common/bench_utils.rs"] | ||
| mod bench_utils; | ||
| use bench_utils::{OrAbort, OrAbortWithContext}; | ||
|
|
||
| fn representative_triangulation() -> DelaunayTriangulation<AdaptiveKernel<f64>, (), (), 2> { | ||
| let mut vertices = Vec::with_capacity(64); | ||
| for row in 0_u32..8 { | ||
| for column in 0_u32..8 { | ||
| let jitter = f64::from((row * 17 + column * 31) % 11) * 1.0e-4; | ||
| vertices.push( | ||
| Vertex::try_new([f64::from(column) + jitter, f64::from(row) - jitter]).or_abort(), | ||
| ); | ||
| } | ||
| } | ||
| DelaunayTriangulationBuilder::new(&vertices) | ||
| .build() | ||
| .or_abort() | ||
| } | ||
|
|
||
| fn checkpoint_benches(criterion: &mut Criterion) { | ||
| let triangulation = representative_triangulation(); | ||
| let checkpoint_json = to_vec(&triangulation).or_abort(); | ||
| let expected_manifest = triangulation.checkpoint_manifest().or_abort(); | ||
| let checkpoint: DelaunayCheckpoint<(), (), 2> = from_slice(&checkpoint_json).or_abort(); | ||
| let restored = checkpoint | ||
| .try_into_delaunay_with_kernel(AdaptiveKernel::new()) | ||
| .or_abort(); | ||
| assert_eq!(restored.checkpoint_manifest().or_abort(), expected_manifest); | ||
| restored.validate().or_abort(); | ||
| restored | ||
| .simplices() | ||
| .next() | ||
| .or_abort("restored checkpoint benchmark must contain a simplex"); | ||
|
|
||
| let mut group = criterion.benchmark_group("checkpoint_serialization/64_vertices"); | ||
| group.throughput(Throughput::Elements(64)); | ||
|
|
||
| group.bench_function("manifest", |bencher| { | ||
| bencher.iter(|| black_box(triangulation.checkpoint_manifest()).or_abort()); | ||
| }); | ||
| group.bench_function("json", |bencher| { | ||
| bencher.iter(|| black_box(to_vec(black_box(&triangulation))).or_abort()); | ||
| }); | ||
| group.bench_function("json_load", |bencher| { | ||
| bencher.iter(|| { | ||
| let checkpoint: DelaunayCheckpoint<(), (), 2> = | ||
| from_slice(black_box(&checkpoint_json)).or_abort(); | ||
| black_box( | ||
| checkpoint | ||
| .try_into_delaunay_with_kernel(AdaptiveKernel::new()) | ||
| .or_abort(), | ||
| ); | ||
| }); | ||
| }); | ||
| group.finish(); | ||
| } | ||
|
|
||
| criterion_group!(benches, checkpoint_benches); | ||
| criterion_main!(benches); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.