OpenCoreKernel: surface silent kernel/kext processing fallback, close leaked KernelFile handle - #613
Closed
albert-mueller wants to merge 2 commits into
Closed
Conversation
… leaked KernelFile handle - OcKernelFileOpen only special-cased EFI_NOT_FOUND from OcKernelReadAppleKernel; any other failure (EFI_UNSUPPORTED, EFI_INVALID_PARAMETER, internal ReadAppleKernel errors) fell through silently to returning the unmodified kernel/kernelcache with no Kernel Add/Patch/Force entries applied, logged only at DEBUG_INFO which is compiled out of RELEASE builds. Now logged at DEBUG_WARN so this is visible in a normal verbose boot log. - OcKernelFuzzyMatch never closed *KernelFile when a candidate kernelcache opened successfully but OcKernelReadAppleKernel failed on it, leaking one EFI_FILE_PROTOCOL handle per rejected candidate in directories with multiple kernelcache files.
OpenCore: Remove duplicate INF_VERSION and gEfiDevicePathProtocolGuid…
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OcKernelReadAppleKernel; any other failure (EFI_UNSUPPORTED,
EFI_INVALID_PARAMETER, internal ReadAppleKernel errors) fell through
silently to returning the unmodified kernel/kernelcache with no Kernel
Add/Patch/Force entries applied, logged only at DEBUG_INFO which is
compiled out of RELEASE builds. Now logged at DEBUG_WARN so this is
visible in a normal verbose boot log.
kernelcache opened successfully but OcKernelReadAppleKernel failed on
it, leaking one EFI_FILE_PROTOCOL handle per rejected candidate in
directories with multiple kernelcache files.
This bug also causes kernel panics on T2 Macs.