Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements #64

Merged
merged 26 commits into from
Feb 23, 2023
Merged

Improvements #64

merged 26 commits into from
Feb 23, 2023

Conversation

nesimtunc
Copy link
Collaborator

@nesimtunc nesimtunc commented Feb 19, 2023 •
edited
Loading

  • Changed environment variables
  • Update README for setup
  • Integration tests
  • Seperate databases (ports as well) based on environment. DEV, TEST, PROD

@nesimtunc
Add app's port info to console log
540b99d
@nesimtunc
Add nodemon to dev dependencies
3c987a7
@nesimtunc
Update environment variables name to avoid conflicts with other services
3984b42
@nesimtunc
Update README for setup
20fa1dc
@nesimtunc
Change App's structure for tests
b694313
@nesimtunc
Write integration test city api
2112b0e
@nesimtunc
Insert types data into db
fad60aa
@nesimtunc
Create type API integration tests
5cf0731
@nesimtunc
Modify the migration script for seeding the db
4a4d95a
@nesimtunc
Create integration tests for sub types API
32ce9e6
@nesimtunc
Seed city and their districts data into db
b45cd25
@nesimtunc
Do not let middleware always override HTTP response status code
87a6e1e
@nesimtunc
Modify locations POST API to return 201
37c3ac2
@nesimtunc
Create test for location POST API
75cbe2c
@nesimtunc
Return newly created location data on insertLocation
42ae616
@nesimtunc
Create test for delete location API
2c23b49
@nesimtunc
Add missing isValidated field to the first migration
10d9618
@nesimtunc
Create tests for listing locations
8a23662
@nesimtunc
Create a location detail API endpoint
7b10cbd
@nesimtunc
Create test for updating locations
fca2afa
@nesimtunc
Remove old unit tests
bed1208
@nesimtunc
Separate environments database
9b703f6
@nesimtunc
Handle some exceptions
18b2151
@nesimtunc
Create test for SQL injections
942acbf
@nesimtunc
Clean up locations table after tests completed (before & after)
bf3fceb
@nesimtunc nesimtunc marked this pull request as ready for review February 19, 2023 09:51
@nesimtunc nesimtunc merged commit 83a3022 into acikyazilimagi:main Feb 23, 2023
@nesimtunc nesimtunc deleted the improvements branch February 23, 2023 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cantoramann cantoramann cantoramann approved these changes

@ouzkilic ouzkilic Awaiting requested review from ouzkilic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nesimtunc @cantoramann