Adapt Papers with Code integration script to use Python library #5482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rationale for freezing was to indicate that this attribute should never be modified manually, since it's (over)written by the PwC integration, but that of course doesn't work if we want the PwC integration itself to go through the library :)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## python-dev #5482 +/- ##
==============================================
- Coverage 93.75% 91.88% -1.87%
==============================================
Files 35 35
Lines 2851 2823 -28
==============================================
- Hits 2673 2594 -79
- Misses 178 229 +51
🚀 New features to boost your workflow:
|
|
See note on #5473. The PwC links all resolve to the Github repo. |
|
Ah, shoot. I suggest we merge this anyway to have the script in case this integration—or a similar one—goes live again, then we can remove the Github action (and potentially other PwC-related stuff) in a separate PR. |
|
On second thought, I think it might be a good idea to remove the PwC-related parts from the Python library for now, and use this PR for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapts
ingest_pwc.pyto use the Python library rather than modify XML directly.Targets
python-devsince the v0.5.3 changes are not merged into master yet, and this also introduces some small modifications to the library.Resolves #5473 (after the script is run at least once on master).