Add some icon tooltips (fixes #143)

acmerobotics · Nov 5, 2023 · a1fc0b6 · a1fc0b6
1 parent b99a1e1
commit a1fc0b6
Show file tree

Hide file tree

Showing 6 changed files with 26 additions and 5 deletions.
diff --git a/FtcDashboard/dash/src/assets/icons/connected.svg b/FtcDashboard/dash/src/assets/icons/connected.svg
diff --git a/FtcDashboard/dash/src/assets/icons/disconnected.svg b/FtcDashboard/dash/src/assets/icons/disconnected.svg
diff --git a/FtcDashboard/dash/src/components/Dashboard/Dashboard.tsx b/FtcDashboard/dash/src/components/Dashboard/Dashboard.tsx
@@ -6,8 +6,8 @@ import { saveLayoutPreset, getLayoutPreset } from '@/store/actions/settings';
 import { RootState } from '@/store/reducers';
 
 import { BaseViewIconButton } from '@/components/views/BaseView';
-import { ReactComponent as ConnectedIcon } from '@/assets/icons/wifi.svg';
-import { ReactComponent as DisconnectedIcon } from '@/assets/icons/wifi_off.svg';
+import { ReactComponent as ConnectedIcon } from '@/assets/icons/connected.svg';
+import { ReactComponent as DisconnectedIcon } from '@/assets/icons/disconnected.svg';
 import { ReactComponent as SettingsIcon } from '@/assets/icons/settings.svg';
 import SettingsModal from './SettingsModal';
 import { startSocketWatcher } from '@/store/middleware/socketMiddleware';
@@ -71,6 +71,7 @@ export default function Dashboard() {
             <DisconnectedIcon className="ml-4 h-10 w-10 py-1" />
           )}
           <BaseViewIconButton
+            title="Settings"
             className="icon-btn group ml-3 h-8 w-8 hover:border-white/50"
             onClick={() => setIsSettingsModalOpen(true)}
           >

diff --git a/FtcDashboard/dash/src/components/views/CameraView.jsx b/FtcDashboard/dash/src/components/views/CameraView.jsx
@@ -74,7 +74,7 @@ class CameraView extends React.Component {
             Camera
           </BaseViewHeading>
           <BaseViewIcons>
-            <BaseViewIconButton>
+            <BaseViewIconButton title="Rotate">
               <RefreshIcon
                 className="h-6 w-6"
                 onClick={() =>

diff --git a/FtcDashboard/dash/src/components/views/ConfigView/ConfigView.tsx b/FtcDashboard/dash/src/components/views/ConfigView/ConfigView.tsx
@@ -98,6 +98,7 @@ const ConfigView = ({
         </BaseViewHeading>
         <BaseViewIcons>
           <BaseViewIconButton
+            title="Save Changes"
             onClick={() => {
               const configDiff = validAndModified(configRoot);
               if (configDiff != null) {
@@ -111,6 +112,7 @@ const ConfigView = ({
             <SaveIcon className="h-6 w-6" />
           </BaseViewIconButton>
           <BaseViewIconButton
+            title="Reload Values"
             onClick={() =>
               dispatch({
                 type: 'REFRESH_CONFIG',

diff --git a/FtcDashboard/dash/src/components/views/GraphView/GraphView.tsx b/FtcDashboard/dash/src/components/views/GraphView/GraphView.tsx
@@ -186,7 +186,10 @@ class GraphView extends Component<GraphViewProps, GraphViewState> {
           </BaseViewHeading>
           <BaseViewIcons>
             {this.state.graphing && this.state.selectedKeys.length !== 0 && (
-              <BaseViewIconButton className="icon-btn h-8 w-8">
+              <BaseViewIconButton
+                title={this.state.paused ? 'Resume Graphing' : 'Pause Graphing'}
+                className="icon-btn h-8 w-8"
+              >
                 {this.state.paused ? (
                   <PlayIcon className="h-6 w-6" onClick={this.play} />
                 ) : (
@@ -195,7 +198,9 @@ class GraphView extends Component<GraphViewProps, GraphViewState> {
               </BaseViewIconButton>
             )}
 
-            <BaseViewIconButton>
+            <BaseViewIconButton
+              title={this.state.graphing ? 'Stop Graphing' : 'Start Graphing'}
+            >
               {this.state.graphing ? (
                 <CloseIcon className="h-6 w-6" onClick={this.stop} />
               ) : (