Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script for facileManager DNS API client #6173

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from

Conversation

gianlucagiacometti
Copy link

No description provided.

Copy link

Welcome
First thing: don't send PR to the master branch, please send to the dev branch instead.
Please make sure you've read our DNS API Dev Guide and DNS-API-Test.
Then reply on this message, otherwise, your code will not be reviewed or merged.
Please also make sure to add/update the usage here: https://github.com/acmesh-official/acme.sh/wiki/dnsapi2
We look forward to reviewing your Pull request shortly ✨
注意: 必须通过了 DNS-API-Test 才会被 review. 无论是修改, 还是新加的 dns api, 都必须确保通过这个测试.

@gianlucagiacometti
Copy link
Author

I enabled github actions and created the appropriate secrets

# Git repo and usage: https://github.com/gianlucagiacometti/proxmox-acme-facilemanager
#

# Values to export:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please convert the options list to a structural info description
https://github.com/acmesh-official/acme.sh/wiki/DNS-API-Structural-Info-description

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I converted the options according to the docs. I will create the documentation in the acmesh-official wiki as required, as soon as the pull request is merged.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I corrected the double double quotes which prevented spellcheck to succeed

@gianlucagiacometti
Copy link
Author

I sent a new version after correcting the mistake which prevented spellcheck to succeed. Should I do something else? I see that no further checks are performed. Thank you and happy new year!

# shellcheck disable=SC2034
dns_fmdns_info='facileManager DNS API
API for self-hosted facileManager DNS.
Domains: github.com/WillyXJ/facileManager
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the Domains: field and put the link to a description:

dns_fmdns_info='facileManager DNS API
 API for self-hosted facileManager DNS github.com/WillyXJ/facileManager
Site: github.com/gianlucagiacometti/proxmox-acme-facilemanager

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants