-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add script for facileManager DNS API client #6173
base: dev
Are you sure you want to change the base?
Conversation
Welcome |
I enabled github actions and created the appropriate secrets |
dnsapi/dns_fmdns.sh
Outdated
# Git repo and usage: https://github.com/gianlucagiacometti/proxmox-acme-facilemanager | ||
# | ||
|
||
# Values to export: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please convert the options list to a structural info description
https://github.com/acmesh-official/acme.sh/wiki/DNS-API-Structural-Info-description
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I converted the options according to the docs. I will create the documentation in the acmesh-official wiki as required, as soon as the pull request is merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I corrected the double double quotes which prevented spellcheck to succeed
I sent a new version after correcting the mistake which prevented spellcheck to succeed. Should I do something else? I see that no further checks are performed. Thank you and happy new year! |
dnsapi/dns_fmdns.sh
Outdated
# shellcheck disable=SC2034 | ||
dns_fmdns_info='facileManager DNS API | ||
API for self-hosted facileManager DNS. | ||
Domains: github.com/WillyXJ/facileManager |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the Domains:
field and put the link to a description:
dns_fmdns_info='facileManager DNS API
API for self-hosted facileManager DNS github.com/WillyXJ/facileManager
Site: github.com/gianlucagiacometti/proxmox-acme-facilemanager
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done it
No description provided.