1st PR #1
Closed
1st PR #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old one was not working idk why, but it had errors and was **not initialised with shadcn** this meant we neeed a new frontend nextjs app:)
Pasting Shadcn for violet theme in the global.css file
Since I am unable to use a svg for the logo i am using the excalidraw font to type the logo. /n What this will do is allow us to use the font again whereever we want so we can highlight the inportant parts of the app:)
Deleting the next app content in layout and page in app directory gives a clean page to work with:)
This commit mailnly deals with the header and footer in the layout page, header rn has the logo and the avatar, the hamburger menu is somthing i am working on, the fotter looks good and the content can be edited by the others. One thing i have in mind for the header is to give it a transparent bg and have a sticky header so it does not got up with the content on scrolling. Also the search is yet to be implemented. \n So the net commit will contain 3 things: **1. Sticky header 2. Hamburger menu 3. Searchbar/icon**:)
| @@ -1,3 +1,3 @@ | |||
| { | |||
| "extends": ["next/core-web-vitals","prettier"] | |||
There was a problem hiding this comment.
DO NOT REMOVE THE FORMATTER PLEASE!!
To uphold code quality, readability, and ease of contribution, prettier is super essential. Please add the package and configs back.
| @@ -6,16 +6,14 @@ | |||
| "dev": "next dev", | |||
| "build": "next build", | |||
| "start": "next start", | |||
| "lint": "next lint", | |||
There was a problem hiding this comment.
DO NOT REMOVE LINTERS AND FORMATTERS!!
It is super crucial to ensure there are no errors at build time and uphold code quality, readability and ease of contribution. Please add the packages and their configurations back.
| import { Avatar, AvatarFallback, AvatarImage } from "@/components/ui/avatar" /*Importinh avatar from shadcn */ | ||
| import Footerwave from "../../public/Footer_Wave.svg"; /*Imporrting the wave svg */ | ||
|
|
||
| const inter = Inter({ subsets: ["latin"] }); |
There was a problem hiding this comment.
Remove fonts that you are sure you will not be using, or move the to a separate file (Inter font)
| const inter = Inter({ subsets: ["latin"] }); | ||
| const Virgil = localFont({ src: './Virgil.woff2' }) /*Importing the virgol font */ | ||
|
|
||
| export const metadata: Metadata = { |
There was a problem hiding this comment.
Add more metadata for SEO friendliness
| <div className=" p-2">{/*This div has the avatar properties */} | ||
| <Avatar> | ||
| <AvatarImage src="https://github.com/shadcn.png" /> | ||
| <AvatarFallback>CN</AvatarFallback> |
There was a problem hiding this comment.
Let the fallback take props too. It will be a nickname stored in the DB as the users initials.
| @@ -0,0 +1 @@ | |||
| {"v":"5.5.8","fr":24,"ip":0,"op":28,"w":50,"h":50,"nm":"searching","ddd":0,"assets":[],"layers":[{"ddd":0,"ind":1,"ty":4,"nm":"line","sr":1,"ks":{"o":{"a":0,"k":100,"ix":11},"r":{"a":0,"k":0,"ix":10},"p":{"a":0,"k":[25,25,0],"ix":2},"a":{"a":0,"k":[25,25,0],"ix":1},"s":{"a":0,"k":[100,100,100],"ix":6}},"ao":0,"shapes":[{"ty":"gr","it":[{"ind":0,"ty":"sh","ix":1,"ks":{"a":0,"k":{"i":[[0,0],[0,0]],"o":[[0,0],[0,0]],"v":[[-6.635,-6.635],[6.635,6.635]],"c":false},"ix":2},"nm":"Path 1","mn":"ADBE Vector Shape - Group","hd":false},{"ty":"tm","s":{"a":1,"k":[{"i":{"x":[0.667],"y":[1]},"o":{"x":[0.333],"y":[0]},"t":3,"s":[0]},{"i":{"x":[0.833],"y":[0.833]},"o":{"x":[0.167],"y":[0.167]},"t":7,"s":[50]},{"i":{"x":[0.667],"y":[1]},"o":{"x":[0.333],"y":[0]},"t":21,"s":[50]},{"t":25,"s":[0]}],"ix":1},"e":{"a":1,"k":[{"i":{"x":[0.667],"y":[1]},"o":{"x":[0.333],"y":[0]},"t":3,"s":[100]},{"i":{"x":[0.833],"y":[0.833]},"o":{"x":[0.167],"y":[0.167]},"t":7,"s":[50]},{"i":{"x":[0.667],"y":[1]},"o":{"x":[0.333],"y":[0]},"t":21,"s":[50]},{"t":25,"s":[100]}],"ix":2},"o":{"a":0,"k":0,"ix":3},"m":1,"ix":2,"nm":"Trim Paths 1","mn":"ADBE Vector Filter - Trim","hd":false},{"ty":"st","c":{"a":0,"k":[0,0,0,1],"ix":3},"o":{"a":0,"k":100,"ix":4},"w":{"a":0,"k":4,"ix":5},"lc":1,"lj":1,"ml":10,"bm":0,"nm":"Stroke 1","mn":"ADBE Vector Graphic - Stroke","hd":false},{"ty":"tr","p":{"a":0,"k":[38.864,38.864],"ix":2},"a":{"a":0,"k":[0,0],"ix":1},"s":{"a":0,"k":[100,100],"ix":3},"r":{"a":0,"k":0,"ix":6},"o":{"a":0,"k":100,"ix":7},"sk":{"a":0,"k":0,"ix":4},"sa":{"a":0,"k":0,"ix":5},"nm":"Transform"}],"nm":"Group 1","np":3,"cix":2,"bm":0,"ix":1,"mn":"ADBE Vector Group","hd":false}],"ip":0,"op":28,"st":0,"bm":0},{"ddd":0,"ind":2,"ty":4,"nm":"circle","sr":1,"ks":{"o":{"a":0,"k":100,"ix":11},"r":{"a":0,"k":0,"ix":10},"p":{"a":0,"k":[25,25,0],"ix":2},"a":{"a":0,"k":[25,25,0],"ix":1},"s":{"a":0,"k":[100,100,100],"ix":6}},"ao":0,"shapes":[{"ty":"gr","it":[{"ind":0,"ty":"sh","ix":1,"ks":{"a":0,"k":{"i":[[8.837,0],[0,-8.836],[-8.836,0],[0,8.837]],"o":[[-8.836,0],[0,8.837],[8.837,0],[0,-8.836]],"v":[[0,-16],[-16,0],[0,16],[16,0]],"c":true},"ix":2},"nm":"Path 1","mn":"ADBE Vector Shape - Group","hd":false},{"ty":"tm","s":{"a":1,"k":[{"i":{"x":[0.667],"y":[1]},"o":{"x":[0.333],"y":[0]},"t":7,"s":[100]},{"t":14,"s":[0]}],"ix":1},"e":{"a":0,"k":0,"ix":2},"o":{"a":0,"k":0,"ix":3},"m":1,"ix":2,"nm":"Trim Paths 1","mn":"ADBE Vector Filter - Trim","hd":false},{"ty":"st","c":{"a":0,"k":[0,0,0,1],"ix":3},"o":{"a":0,"k":100,"ix":4},"w":{"a":0,"k":2,"ix":5},"lc":2,"lj":1,"ml":10,"bm":0,"nm":"Stroke 1","mn":"ADBE Vector Graphic - Stroke","hd":false},{"ty":"tr","p":{"a":1,"k":[{"i":{"x":0.667,"y":1},"o":{"x":0.333,"y":0},"t":3,"s":[21,20],"to":[0.742,0.751],"ti":[-0.742,-0.751]},{"t":7,"s":[25.451,24.508]}],"ix":2},"a":{"a":0,"k":[0,0],"ix":1},"s":{"a":1,"k":[{"i":{"x":[0.667,0.667],"y":[1,1]},"o":{"x":[0.333,0.333],"y":[0,0]},"t":3,"s":[100,100]},{"t":7,"s":[128,128]}],"ix":3},"r":{"a":0,"k":0,"ix":6},"o":{"a":0,"k":100,"ix":7},"sk":{"a":0,"k":0,"ix":4},"sa":{"a":0,"k":0,"ix":5},"nm":"Transform"}],"nm":"Group 2","np":3,"cix":2,"bm":0,"ix":2,"mn":"ADBE Vector Group","hd":false}],"ip":0,"op":14,"st":0,"bm":0},{"ddd":0,"ind":3,"ty":4,"nm":"circle 2","sr":1,"ks":{"o":{"a":0,"k":100,"ix":11},"r":{"a":0,"k":0,"ix":10},"p":{"a":0,"k":[25,25,0],"ix":2},"a":{"a":0,"k":[25,25,0],"ix":1},"s":{"a":0,"k":[100,100,100],"ix":6}},"ao":0,"shapes":[{"ty":"gr","it":[{"ind":0,"ty":"sh","ix":1,"ks":{"a":0,"k":{"i":[[8.837,0],[0,-8.836],[-8.836,0],[0,8.837]],"o":[[-8.836,0],[0,8.837],[8.837,0],[0,-8.836]],"v":[[0,-16],[-16,0],[0,16],[16,0]],"c":true},"ix":2},"nm":"Path 1","mn":"ADBE Vector Shape - Group","hd":false},{"ty":"tm","s":{"a":0,"k":100,"ix":1},"e":{"a":1,"k":[{"i":{"x":[0.667],"y":[1]},"o":{"x":[0.333],"y":[0]},"t":14,"s":[100]},{"t":21,"s":[0]}],"ix":2},"o":{"a":0,"k":0,"ix":3},"m":1,"ix":2,"nm":"Trim Paths 1","mn":"ADBE Vector Filter - Trim","hd":false},{"ty":"st","c":{"a":0,"k":[0,0,0,1],"ix":3},"o":{"a":0,"k":100,"ix":4},"w":{"a":0,"k":2,"ix":5},"lc":2,"lj":1,"ml":10,"bm":0,"nm":"Stroke 1","mn":"ADBE Vector Graphic - Stroke","hd":false},{"ty":"tr","p":{"a":1,"k":[{"i":{"x":0.667,"y":1},"o":{"x":0.333,"y":0},"t":21,"s":[25.451,24.508],"to":[-0.742,-0.751],"ti":[0.742,0.751]},{"t":25,"s":[21,20]}],"ix":2},"a":{"a":0,"k":[0,0],"ix":1},"s":{"a":1,"k":[{"i":{"x":[0.667,0.667],"y":[1,1]},"o":{"x":[0.333,0.333],"y":[0,0]},"t":21,"s":[128,128]},{"t":25,"s":[100,100]}],"ix":3},"r":{"a":0,"k":0,"ix":6},"o":{"a":0,"k":100,"ix":7},"sk":{"a":0,"k":0,"ix":4},"sa":{"a":0,"k":0,"ix":5},"nm":"Transform"}],"nm":"Group 2","np":3,"cix":2,"bm":0,"ix":2,"mn":"ADBE Vector Group","hd":false}],"ip":14,"op":28,"st":0,"bm":0}],"markers":[]} | |||
There was a problem hiding this comment.
Try to animate the footer wave svg with CSS.
| @@ -18,7 +18,7 @@ | |||
| } | |||
| ], | |||
| "paths": { | |||
| "@/*": ["./*"] | |||
| "@/*": ["./src/*"] | |||
There was a problem hiding this comment.
Refrain from using the src directory
While it is a good practice in other projects. We will not be using the src directory for our use case. Please init the project without the src directory.
achyuthcodes30
requested changes
Mar 13, 2024
There was a problem hiding this comment.
Requested changes:
-
Please add the formatter and linter packages along with their configs back to the project and utilize them to maintain code quality.
-
Please refrain from using the src directory for this project. Re init without it.
-
Animate the footer svg and style the footer as well.
-
Make sure the Avatar Fallback takes props too. This is essential as we will be displaying the users initals stored in the database as a fallback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr has multiple commits integrating all of the work i have done till now.