Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I have fixed the navbar to the top of the website. #91

Closed
wants to merge 2 commits into from

Conversation

nigeldias27
Copy link

@nigeldias27 nigeldias27 commented Oct 15, 2021

Title

I have fixed the navbar to the top of the website. On scrolling it will not be visible

Description

When scrolling the navbar is not visible. I have done so by:

  1. Removing fixed-top from nav element class name
  2. Moved the Navbar into a div whose id is particles-js so that the background is the same as that of the div
  3. Created a media query so when the device width is smaller than 991px the background is white otherwise it is the same as that of the div mentioned in point 2 in styles.css
  4. Removing the text-shadow of text because the text was visible when opening the navbar menu

Issue Closed

If your PR closes an issue, mention it here replacing XX with the issue number. Ex: Closes #XX
Closes #88

@chick-bot
Copy link

chick-bot bot commented Oct 15, 2021

Hi, @nigeldias27! Thank you for your Pull Request 🥳🚀 A Maintainer will review your PR Shortly. Till then, hold tight!

@arnxv0
Copy link
Collaborator

arnxv0 commented Oct 15, 2021

Hey, good work, check the guidelines again. There has been a minor change.

@nigeldias27
Copy link
Author

I'm sorry, I don't understand. Which guidelines are you referring to? Is there an issue with the code or the way I submitted it on github?

@techverve
Copy link
Member

I'm sorry, I don't understand. Which guidelines are you referring to? Is there an issue with the code or the way I submitted it on github?

check issue description, that has the guidelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navbar not visible while scrolling
3 participants