Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Andy/community page redesign (desktop, partial mobile) #306

Merged
merged 35 commits into from
Dec 25, 2024

Conversation

WishingWell13
Copy link
Contributor

@WishingWell13 WishingWell13 commented Sep 6, 2024

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue) (Remove if there isn't an issue this fixes. If this relates to an internal Notion issue, link to that instead (or in addition to))

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Logistical Change (something about code process / a readme change / documentation update)
  • CI Change (relating to deployment / continuous integration)
  • Something Else

How Has This Been Tested?

  • Tested on Localhost (Desktop)
  • Tested on Localhost (Mobile) - use https://ngrok.io to get a copy on a mobile device
  • Tested on Deployed Preview (Desktop)
  • Tested on Deployed Preview (Mobile)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code as needed, particularly in hard-to-understand areas
  • My changes generate no new warnings (if they do, please explain why)

WishingWell13 and others added 2 commits August 29, 2024 19:14
Work Done During Next Type Work Hacks


* Initial commit

* Removed note about nvm use

* Added single logo+title+full name component

Hidden, need to uncomment in Communiyt.Suborgs.tsx to see

No drop shadow yet

* Selector V1 Done (no description shown yet)

Added community specific implementations of the CommunityTitle

Clicking on the logo opens up the title text

Logos shrink when page gets smaller

No gradient yet

* added drop shadow on hover

* fixed hover

* added active link effect

* Reverted package.json change

also reran yarn

* Partial revert of yarn lock and yarn rc files

* Allowed drop shadow to be on hover

* Fixed double hover issue + text glowing

* communities and initiatives toggle (no functionality yet) added

* Placeholder for initiative navbar

Need to figure out rainbow gradient

* Temporary placeholder images for initiative navbar

* redesigned layout of logos for communities and initiatives

* Replaced logos, temporary rainbow gradient

* Made org description show up depending on what is selected

Not implemented for communities yet

* basic glow set up, needs to be fixed

* glow on hover more updates

* updates

* CommunityImage component with temporary images

No click to expand

* Added description components for initiatives

* Renabled glow and initiative descriptions integrated

Now clicking on a logo in initiatives section will open corresponding description

* Fixing titles, reducing redundant code

* added grid image layout as part of community descriptions

* Removed duplicate from merge, removed bg color from images

* Fixed spacing with grid images

* Adjusted sizing of the image grid

* Code quality renaming

Removed extra line in package json

---------

Co-authored-by: comnk <[email protected]>
Copy link

vercel bot commented Sep 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
main-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 25, 2024 7:16pm

testing to see if this helps vercel
Made width of content description and selection bar match the rest of the webpage if you zoom out super far
Copy link
Member

@SheepTester SheepTester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

communities/intiatives tab doesnt render properly on mobile

image

some nitpicks, mostly about the buttons not having cursor: pointer because they aren't <button>s

public/assets/communities-links/palm-tree.png Outdated Show resolved Hide resolved
src/sections/community/Community.Suborgs.tsx Show resolved Hide resolved
src/sections/community/Community.Suborgs.tsx Show resolved Hide resolved
src/sections/community/Community.Hero.tsx Outdated Show resolved Hide resolved
Copy link
Member

@SheepTester SheepTester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 yeah looks good, lets merge this

src/sections/community/Community.Suborgs.tsx Outdated Show resolved Hide resolved
Reference store item page in portal v2

Also updated Cyber images
@WishingWell13 WishingWell13 changed the title Andy/community page redesign Andy/community page redesign (desktop, partial mobile) Dec 25, 2024
@WishingWell13 WishingWell13 merged commit 267007d into main Dec 25, 2024
3 checks passed
@WishingWell13 WishingWell13 deleted the andy/community-page-redesign branch December 25, 2024 19:37
@WishingWell13 WishingWell13 linked an issue Dec 25, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Communities Page Description and Socials Component
2 participants