Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial scaffolding for store orders page #100

Merged
merged 8 commits into from
Dec 30, 2023

Conversation

alexzhang1618
Copy link
Contributor

@alexzhang1618 alexzhang1618 commented Dec 28, 2023

Description

What changes did you make? List all distinct problems that this PR addresses. Explain any relevant
motivation or context.

Initial code for store orders page in, putting in layout and filtering for full page.
In a follow up PR I'll add in viewing the info of a particular order and other order flow stuff.

Changes

  • fix some Typography sizes
  • Implement OrderCard
  • Implement OrdersDisplay
  • Add a new API call to get all orders for the current user
  • Add greater date util functions in utils.ts (allowing for the year to also be added in the format)
    • This will also be useful down the line for past event displays
  • Implement Orders Page and dropdown for time filtering of orders
  • Fix/add some colors that were needed in vars.scss

Type of Change

  • Bug Fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • Logistics Change (A change to a README, description, or dev workflow setup like
    linting/formatting)
  • Continuous Integration Change (Related to deployment steps or continuous integration
    workflows)
  • Other: (Fill In)

Testing

I have tested that my changes fully resolve the linked issue ...

  • locally on Desktop.
  • locally on mobile - use https://ngrok.io to get a copy on a mobile device
  • on the live deployment preview on Desktop.
  • on the live deployment preview on Mobile.
  • I have run and passed all new and existing Cypress tests. Add screenshots below.

Checklist

  • I have performed a self-review of my own code.
  • I have followed the style guidelines of this project.
  • I have documented my code's src/lib functions and commented hard to understand areas
    anywhere else.
  • My changes produce no new warnings.

Screenshots

Screenshot 2023-12-28 at 2 57 57 PM Screenshot 2023-12-28 at 2 58 19 PM

Copy link

vercel bot commented Dec 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
membership-portal-ui-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 30, 2023 5:13am

Copy link
Member

@farisashai farisashai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial code review, haven't looked at a preview

src/components/store/OrderCard/index.tsx Outdated Show resolved Hide resolved
src/lib/api/StoreAPI.ts Outdated Show resolved Hide resolved
src/lib/api/StoreAPI.ts Outdated Show resolved Hide resolved
src/pages/store/orders.tsx Outdated Show resolved Hide resolved
Copy link
Member

@farisashai farisashai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small feedback but looks good for now. When the page is more finalized I'll review the actual UI

src/lib/types/enums.ts Outdated Show resolved Hide resolved
src/components/store/OrdersDisplay/index.tsx Outdated Show resolved Hide resolved
src/pages/store/orders.tsx Outdated Show resolved Hide resolved
@alexzhang1618 alexzhang1618 merged commit ea974c2 into main Dec 30, 2023
4 checks passed
@alexzhang1618 alexzhang1618 deleted the feature/store-orders-page branch December 30, 2023 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants