Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial layout for events page #103

Merged
merged 8 commits into from
Jan 2, 2024
Merged

Initial layout for events page #103

merged 8 commits into from
Jan 2, 2024

Conversation

alexzhang1618
Copy link
Contributor

Description

What changes did you make? List all distinct problems that this PR addresses. Explain any relevant
motivation or context.

  • Laying out a prototype for an events page database
  • Refactored Leaderboard.tsx to pull out lots of year stuff and make it common for both the Events and Leaderboard pages
  • Kind of want to be able to adjust dropdown size for the common component (right now I've upscaled the search bar text to match, but I'd like to make both smaller)
  • Would like feedback on the design/features that could be added

Type of Change

  • Bug Fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • Logistics Change (A change to a README, description, or dev workflow setup like
    linting/formatting)
  • Continuous Integration Change (Related to deployment steps or continuous integration
    workflows)
  • Other: (Fill In)

Testing

I have tested that my changes fully resolve the linked issue ...

  • locally on Desktop.
  • locally on mobile - use https://ngrok.io to get a copy on a mobile device
  • on the live deployment preview on Desktop.
  • on the live deployment preview on Mobile.
  • I have run and passed all new and existing Cypress tests. Add screenshots below.

Checklist

  • I have performed a self-review of my own code.
  • I have followed the style guidelines of this project.
  • I have documented my code's src/lib functions and commented hard to understand areas
    anywhere else.
  • My changes produce no new warnings.

Screenshots

Screenshot 2023-12-30 at 11 27 48 PM Screenshot 2023-12-30 at 11 28 03 PM Screenshot 2023-12-30 at 11 28 22 PM

Copy link

vercel bot commented Dec 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
membership-portal-ui-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2024 3:17am

Copy link
Member

@farisashai farisashai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the search bar should be be white-space and case-insensitive and strip non alphanumeric characters so a search term like "aiintro toneuraL" would match the event "AI: Intro to Neural Networks"

src/pages/events.tsx Outdated Show resolved Hide resolved
src/pages/events.tsx Outdated Show resolved Hide resolved
src/pages/leaderboard.tsx Outdated Show resolved Hide resolved
src/pages/events.tsx Show resolved Hide resolved
@alexzhang1618 alexzhang1618 merged commit 72dd58c into main Jan 2, 2024
4 checks passed
@alexzhang1618 alexzhang1618 deleted the feature/events-page branch January 2, 2024 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants