Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo cleanup #110

Merged
merged 38 commits into from
Jan 19, 2024
Merged

Repo cleanup #110

merged 38 commits into from
Jan 19, 2024

Conversation

farisashai
Copy link
Member

@farisashai farisashai commented Jan 2, 2024

Description

Cleanup and some improvements

I wouldn't merge this until after all of the major PRs are closed so the fixes that apply there too can be added in without introducing more merge conflicts.

Changes

  • Removed unnecessary scaffolding code from when I initialized this repo for navbar props (we can directly intercept the pageProps to see if the user is logged in and don't have to store any state)
  • Clear cookie function to support future flexibility if we add additional cookie types
  • Corrected some data types and made components more concise
  • Renamed PermissionService.allUserTypes to be more descriptive in page access restrictions
  • Blocked user.state cannot log in or restricted user.accessType
  • 404 page is not relevant enough to need user data, just redirect to home page and let them recover from there
  • Store dropdown divider in a constant instead of being a magic variable
  • Added support for the project as a Progressive Web App. Biggest change is that a user can click add to home screen on mobile and it will open as a native app instead of in a web browser, but PWAs also have lots of other benefits for improving caching and native experiences.

Type of Change

  • Bug Fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • Logistics Change (A change to a README, description, or dev workflow setup like
    linting/formatting)
  • Continuous Integration Change (Related to deployment steps or continuous integration
    workflows)
  • Other: (Fill In)

Testing

I have tested that my changes fully resolve the linked issue ...

  • locally on Desktop.
  • locally on mobile - use https://ngrok.io to get a copy on a mobile device
  • on the live deployment preview on Desktop.
  • on the live deployment preview on Mobile.
  • I have run and passed all new and existing Cypress tests. Add screenshots below.

Checklist

  • I have performed a self-review of my own code.
  • I have followed the style guidelines of this project.
  • I have documented my code's src/lib functions and commented hard to understand areas
    anywhere else.
  • My changes produce no new warnings.

Copy link

vercel bot commented Jan 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
membership-portal-ui-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 19, 2024 8:02am

Copy link
Contributor

@alexzhang1618 alexzhang1618 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for whenever we want this merged

src/pages/index.tsx Outdated Show resolved Hide resolved
@farisashai farisashai merged commit 9bd9620 into main Jan 19, 2024
5 checks passed
@farisashai farisashai deleted the faris/misc-fixes branch January 19, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants