-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finish main page hero #112
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like how you linked every other page from the home page in a good way without needing to use the navbar. I honestly think we should have a "about acm" or "learn more" link in this home section and completely remove the link from the main navigation since it's so insignificant
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
design suggestions:
you could change the padding for .checkin
to padding: 1.5rem
so it lines up with the link icons
there's a lot of different font sizes in the hero. I think you should make all the smaller font sizes in the hero the same size for consistency. the smaller the better, because having text too big can feel claustrophobic and ruin the hierarchy (people might skim over it like they're headings or ads, and it can be hard to read)
I'd also reduce the line height of the big "Welcome to ACM" text, as well as increasing the spacing between that and the membership points
Also I think you mixed up the store and leaderboard icons
Since the last review:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if the typography component is specified as a "a", we should actually be rendering a <Link>
component to handle client side routing for us but otherwise changes look good
…embership-portal-ui-v2 into feature/main-page-hero
Description
What changes did you make? List all distinct problems that this PR addresses. Explain any relevant
motivation or context.
Things to do:
Type of Change
expected)
linting/formatting)
workflows)
Testing
I have tested that my changes fully resolve the linked issue ...
Checklist
src/lib
functions and commented hard to understand areasanywhere else.
Screenshots
Normal screens
Wide screens
Mobile screens