Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Faris/cleanup optimizations #113

Merged
merged 9 commits into from
Jan 4, 2024
Merged

Faris/cleanup optimizations #113

merged 9 commits into from
Jan 4, 2024

Conversation

farisashai
Copy link
Member

some cleanup and optimizations for repo

  • serversideprops should return as little data as possible, moved event slicing to serverside since the slice range is already hardcoded in
  • shallow navigate page routes with native nextjs router to avoid recalculating serversideprops
  • default event page to all time so the page isn't empty on initial load ever
  • format event links without https:// correctly instead of assuming relative links
  • fix hydration error trying to run the browser blob api serverside pre-rendering
  • load gifs correctly in top 3 user cards

@vercel Vercel
Copy link

vercel bot commented Jan 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
membership-portal-ui-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 4, 2024 5:12am

alexzhang1618
alexzhang1618 reviewed Jan 4, 2024
View reviewed changes
src/pages/index.tsx Outdated Show resolved Hide resolved
alexzhang1618
alexzhang1618 approved these changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@alexzhang1618 alexzhang1618 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 😁

@farisashai farisashai merged commit 9aa0a1e into main Jan 4, 2024
4 checks passed
@farisashai farisashai deleted the faris/cleanup-optimizations branch January 4, 2024 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexzhang1618 alexzhang1618 alexzhang1618 approved these changes

@raymosun raymosun Awaiting requested review from raymosun raymosun is a code owner

@trevorkw7 trevorkw7 Awaiting requested review from trevorkw7 trevorkw7 is a code owner

@SheepTester SheepTester Awaiting requested review from SheepTester SheepTester is a code owner

Assignees

@farisashai farisashai

Labels
PR: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@farisashai @alexzhang1618