Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin Features #114

Merged
merged 5 commits into from
Jan 7, 2024
Merged

Admin Features #114

merged 5 commits into from
Jan 7, 2024

Conversation

farisashai
Copy link
Member

@farisashai farisashai commented Jan 4, 2024

Info

Initial Scaffolding for Admin Home Page

this will be the next biggest set of features to complete once everything user facing is done (can be completely after releasing v2 publicly) - most urgent task admin side will probably be editing and managing store items to upload multiple item images

the goal of this PR is just to set a decent foundation wiring up all links and actions (will need major styling revamps later on)

Description

  • added link to admin settings page on mobile
  • added buttons for all possible admin features

Type of Change

  • Bug Fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • Logistics Change (A change to a README, description, or dev workflow setup like
    linting/formatting)
  • Continuous Integration Change (Related to deployment steps or continuous integration
    workflows)
  • Other: (Fill In)

Testing

I have tested that my changes fully resolve the linked issue ...

  • locally on Desktop.
  • locally on mobile - use https://ngrok.io to get a copy on a mobile device
  • on the live deployment preview on Desktop.
  • on the live deployment preview on Mobile.
  • I have run and passed all new and existing Cypress tests. Add screenshots below.

Checklist

  • I have performed a self-review of my own code.
  • I have followed the style guidelines of this project.
  • I have documented my code's src/lib functions and commented hard to understand areas
    anywhere else.
  • My changes produce no new warnings.

Screenshots

Please include a screenshot of your Cypress testing suite passing successfully.

If you made any visual changes to the website, please include relevant screenshots below.

Copy link

vercel bot commented Jan 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
membership-portal-ui-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 7, 2024 4:20am

Copy link
Contributor

@alexzhang1618 alexzhang1618 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM but I'd wait for another review before merging 👹

src/pages/admin/milestone.tsx Outdated Show resolved Hide resolved
Copy link
Member

@SheepTester SheepTester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that you un-hardcoded the mobile navbar height

src/pages/admin/milestone.tsx Show resolved Hide resolved
@farisashai farisashai merged commit 26bead4 into main Jan 7, 2024
4 checks passed
@farisashai farisashai deleted the faris/admin-features branch January 7, 2024 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants