Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First experiments with user banners: #140

Closed
wants to merge 1 commit into from

Conversation

alexzhang1618
Copy link
Contributor

Info

Closes #120.

  • Still in progress

Changes

  • [Fill in here]

Type of Change

  • Bug Fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • Logistics Change (A change to a README, description, or dev workflow setup like
    linting/formatting)
  • Continuous Integration Change (Related to deployment steps or continuous integration
    workflows)
  • Other: (Fill In)

Testing

I have tested that my changes fully resolve the linked issue ...

  • locally on Desktop.
  • on the live deployment preview on Desktop.
  • on the live deployment preview on Mobile.
  • I have added new Cypress tests that are passing.

Checklist

  • I have performed a self-review of my own code.
  • I have followed the style guidelines of this project.
  • I have documented any new functions in /src/lib/* and commented hard to understand areas
    anywhere else.
  • My changes produce no new warnings.

Screenshots

Copy link

vercel bot commented Jan 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
membership-portal-ui-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 27, 2024 11:13pm

@@ -34,7 +35,7 @@ export const UserProfilePage = ({
return (
<div className={styles.profilePage}>
<div className={styles.cardWrapper}>
<div className={styles.banner} />
<UserBanner attendances={isSignedInUser ? signedInAttendances : attendances} />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you view raymond's banner, it's blank because his attendances are private. maybe have some fallback

Copy link
Member

@farisashai farisashai Jan 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also since we want this feature to be a public part of the user profile, we can't rely on the user's own attendance either if it's private because that will display differently for them than how other users see their profile

@farisashai
Copy link
Member

right now every user's profile banner looks exactly the same. I think you should play around with using a random seed of the user's uuid to generate the location of the colors or something like that, and then you can calculate the intensity using their attendances or default to an equal intensity for all communities if the attendances are private.

@alexzhang1618 alexzhang1618 deleted the custom-user-banners branch March 31, 2024 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants