Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make admin event mobile responsive, remove unused CSS in CheckInModal #153

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

alexzhang1618
Copy link
Contributor

@alexzhang1618 alexzhang1618 commented Feb 20, 2024

Info

Closes #146.

Changes

  • Makes Admin Event Form mobile responsive
    • labels pop up over form item, flex wraps on buttons, image resizes with width
  • Also removing unused CSS from CheckInModal that was left from previous iterations

Type of Change

  • Bug Fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • Logistics Change (A change to a README, description, or dev workflow setup like
    linting/formatting)
  • Continuous Integration Change (Related to deployment steps or continuous integration
    workflows)
  • Other: (Fill In)

Testing

I have tested that my changes fully resolve the linked issue ...

  • locally on Desktop.
  • on the live deployment preview on Desktop.
  • on the live deployment preview on Mobile.
  • I have added new Cypress tests that are passing.

Checklist

  • I have performed a self-review of my own code.
  • I have followed the style guidelines of this project.
  • I have documented any new functions in /src/lib/* and commented hard to understand areas
    anywhere else.
  • My changes produce no new warnings.

Screenshots

Desktop (original)
https://github.com/acmucsd/membership-portal-ui-v2/assets/27360825/3e298c97-9887-4dd4-ae2e-2a64c375da2e

Mobile (new)
https://github.com/acmucsd/membership-portal-ui-v2/assets/27360825/29765e52-3dca-4e2f-8014-868bc68ec9a8

Copy link

vercel bot commented Feb 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
membership-portal-ui-v2 ✅ Ready (Inspect) Visit Preview Feb 20, 2024 11:27pm

@alexzhang1618 alexzhang1618 merged commit f4deac9 into main Feb 21, 2024
6 checks passed
@alexzhang1618 alexzhang1618 deleted the feature/admin-event-mobile branch February 21, 2024 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants